Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View of File Downloads should show all products referencing the private file #529

Open
herbdool opened this issue Feb 18, 2025 · 4 comments · May be fixed by #530
Open

View of File Downloads should show all products referencing the private file #529

herbdool opened this issue Feb 18, 2025 · 4 comments · May be fixed by #530

Comments

@herbdool
Copy link
Contributor

On the admin view for File Downloads, admin/store/products/files it appears that it's only showing one of the products. You can replicate by adding the same file to multiple products. Only one will appear.

@herbdool
Copy link
Contributor Author

@bugfolder @argiepiano I've got a PR for this. It's a relatively straightforward change to the display. Each file can be associated with one or more products; and one or more SKUs on the same product. So I updated it to show each one. Without this change it seems like one would not be able to reuse a file, even though it is possible.

Image

@argiepiano
Copy link
Collaborator

@herbdool thanks for providing the PR. I've tested and have verified the bug, and also that the PR fixes it. LGTM!

Question: in my testing I noticed the uploaded files remain as "Temporary". Are you seeing this too? Is this a bug?

@herbdool
Copy link
Contributor Author

@argiepiano oh, you're right. I hadn't noticed that before that they remain "Temporary". A bug probably. Create a new issue?

@argiepiano
Copy link
Collaborator

Yes, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants