-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer #18
Comments
What am I overlooking? I can not find anyplace to edit the mini-layout. The instructions to the right does not 'add up'. Otherwise: Really impressive project, but might be overwhelming for newcomers. |
@Egmund Thanks so much for this feedback. It's nice to know that others are looking at and/or experimenting with this project. It's also nice to know what kind of problems/confusion you are experiencing. I've been debating whether or not Mini layouts is the best solution for the footer. I had concerns that folks unfamiliar with Mini layouts would experience the confusion that you are reporting. Editing mini-layouts is not very intuitive and I may petition the maintainer of Mini layouts to see if there is something we can do to make it easier. To edit a mini-layout, you have to:
I understand that this is confusing. I choose Mini layouts for the footer, because I needed some way to create three columns in the footer. None of the default layouts have more than one column in the footer. The two most obvious solutions for me were:
Neither of these seem like the ideal solution. I will see if we can find some way to make Mini layouts easier to use, within this recipe or possibily consider the other option. I welcome other ideas. |
Ah, yes. And I wonder how I overlooked this. |
Update:
Of course these three regions were added to the Sutro info.
I made the 'Social Media' block reusable as well. |
Getting the hang of it: |
Yes, creating an alternative layout would be one possible solution. But, my goal is that someone is able to create this site by ONLY downloading two items. 1) The Digital Agency Recipe Package AND 2) any theme that supports it. I would love for everything to be included as a dependency of one or the other of these items. At the moment, it's not possible to include a dependency on a contrib layout template in either a module or a theme. This leaves me looking for a solution that does not involve adding a new layout template file. However, this does give me an idea. A theme or a module can override an existing layout template file. So, I could hack one the existing core templates to place 3 or 4 columns in the footer. The main downside to this solution is that I'm changing a core layout template in unexpected and potentially confusing ways for folks who might not understand what is going on. The hack would only be in effect as long as the recipe is enabled (and any theme could override my hack). I can try to mitigate this with documentation in the Readme file, but it's still a hack. I think I'm going to try it. I'm also going to try and push for a change to core that will allow me to make a contrib layout template file a dependency in a recipe. Than I could just create a custom layout template for this recipe, release it in contrib, and make it a dependency. |
@Egmund Are you a member of the Backdrop CMS Contrib group on Github? That is the only requirement to share your Layout Template file in the contrib space. |
I will look into becoming a contrib member. |
The wordpress theme uses flexbox in the footer. I have played a little with it (flex-box)and have duplicated the version in mini-layouts. That was fairly simple, but this probably would be complicated to incorporate in Digital Agency. Maybe another sub-receip. |
I have duplicated the footer mini-layout with a custom block (raw html) containing the following. Also needed was to add the footer-region css with copy ot footer mini-layout css:
With a 'width' of 'auto' or another percentage other count of columns could be set up. |
I have tried to be accepted now twice. Maybe it is a long/slow process - more than a month. |
I am sorry about this. It is usually not this long. Sometimes its very quick. Let me see if we can get this taken care of for you now. @Egmund Can you respond to the questions that @herbdool asked? |
Just in case they can be pulled in as dependencies - my layouts with 3 columns in top footer are now publicly available - a bundle with clones of all core layouts. |
Here is what the original Zeever has:
![image](https://private-user-images.githubusercontent.com/3144571/338883077-c6e4677f-a62f-4dc6-9388-6723652ead8a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjk2MjMsIm5iZiI6MTczOTAyOTMyMywicGF0aCI6Ii8zMTQ0NTcxLzMzODg4MzA3Ny1jNmU0Njc3Zi1hNjJmLTRkYzYtOTM4OC02NzIzNjUyZWFkOGEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMTU0MjAzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWYyZDQ5M2U5YzQxZDUxZDVmYjYzYjBiMTAzNTgzNjNlNTA3NjY4YzE5MzRlYmEwYTM3Njk3MjFmNzYxMTBiYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.iYv1k7NIUdv_ihzcs3Jth5P6J8tPBf1RYcrM1cvz37k)
I've partially implemented a footer. But, so far it only has 3 columns and it's using mini-layouts. I'm not sure that mini-layouts in the best solution.
The text was updated successfully, but these errors were encountered: