Bacpop-207 Add info_csv file for metadata #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beebop/app.py
Outdated
| @@ -325,7 +327,7 @@ def run_poppunk_internal(sketches: dict, | |||
|
|
|||
|
|
|||
| def setup_db_file_stores( | |||
| species_args: dict, | |||
| species_args: Any, | |||
There was a problem hiding this comment.
You've made this change because species_args isn't a dict but an object with attributes? Is it worth making a class for this rather than generic Any?
There was a problem hiding this comment.
good idea have done
| @@ -45,6 +45,7 @@ | |||
| "fulldb": "GPS_v9", | |||
| "external_cluster_prefix": "GPSC", | |||
| "external_clusters_file": "GPS_v9_external_clusters.csv", | |||
| "db_metadata_file": "GPS_metadata.csv", | |||
There was a problem hiding this comment.
I wonder if this filename should be tagged to the db version..? Or is the idea that this will contain metadata for all samples in all versions of the db?
There was a problem hiding this comment.
yeah its not really db version-specific
Base automatically changed from
bacpop-205-fix-network
to
bacpop-186-v9-db-support
January 14, 2025 12:15
…g, update type annotations
…beebop_py into bacpop-207-csv-branched
…beebop_py into bacpop-207-csv-branched
…beebop_py into bacpop-207-csv-branched
EmmaLRussell
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new metadata csv file that is passed into microreact (info_csv).. This data will now show up when visiting microeact (have to toggle columns)... Also if there is latitude, longitude in csv it will plot map, and if year info then plot timeline.
Also this PR changes the title of the microreact page to "Cluster {cluster_num} - {datetime}"
This is deployed to dev and can be seen when running project and visiting microreact.
Note: current metadata file is only gpsc 1-30 and not complete... thus there will be lots of empty fields.
Testing: