Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project structure change for yml but still no improvements #63

Open
badarshahzad opened this issue Nov 28, 2017 · 11 comments
Open

project structure change for yml but still no improvements #63

badarshahzad opened this issue Nov 28, 2017 · 11 comments

Comments

@badarshahzad
Copy link
Owner

Guys, I have tried but still no improvements in maven build error what to do now? 🚶‍♂️
screenshot from 2017-11-29 02 40 25

@badarshahzad
Copy link
Owner Author

👋 well they email us we are failed again to build in maven 😄
screenshot from 2017-11-29 02 42 14

@goxr3plus
Copy link
Collaborator

The project structure now is lit fire 🔥 good work.

@goxr3plus
Copy link
Collaborator

goxr3plus commented Nov 28, 2017

@badarshahzad Because I am away from any computer, can you try and run locally on your computer in the same folder as the pom. xml file on the terminal or command prompt the command mvn clean package.

It should run all the way correctly and produce the target folder along with browser jar file and libraries.

@badarshahzad
Copy link
Owner Author

yeaaah! Build Success! 💯
screenshot from 2017-11-29 03 12 31

@badarshahzad
Copy link
Owner Author

@goxr3plus don't you notice the total time 👍

@goxr3plus
Copy link
Collaborator

@badarshahzad Something seems wrong here. I don't see anywhere in the picture the procedure of copying the required dependencies to the external folder.

@goxr3plus
Copy link
Collaborator

@badarshahzad Do you see JFX-Browser_lib folder inside the target folder side by side the jar file.

If yes does it contains the libraries?

@badarshahzad
Copy link
Owner Author

@goxr3plus Nope, I didn't find any lib directory.

@goxr3plus
Copy link
Collaborator

goxr3plus commented Nov 29, 2017

@badarshahzad Yep because you did run mvn clean now I have seen it :).

Instead try and run mvn clean package

I am preparing Maven tutorials on YouTube.

@badarshahzad
Copy link
Owner Author

This is the result after after run mvn clean package
error

What do you think about gradle? Don't we add gradle dependance?

@goxr3plus
Copy link
Collaborator

goxr3plus commented Nov 29, 2017

It fails because you need Maven 3.0.0 and above. I have made it like this :)

Gradle is like Maven but different. We use either the one or the other.

Actually there are many systems. Google Maven VS Gradle VS Ivy VS Ant The most recent is Gradle which come to resolve Maven problems and more. Actually it is written in Groovy, which is a very beautiful language.

It is a little bit more complex, I am not very experienced with Gradle yet :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants