Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9 Compatibility #70

Open
pdemanget opened this issue Feb 21, 2018 · 2 comments
Open

Java 9 Compatibility #70

pdemanget opened this issue Feb 21, 2018 · 2 comments

Comments

@pdemanget
Copy link

Could you upgrade the dependency of JFoenix version for java9 Compatibility?
see bug: sshahine/JFoenix#365

Of course, if you want to keep java8 compatibility, you have to maintain 2 branches.

Here is the patch that works for me in JDK9:

diff --git a/build.gradle b/build.gradle
index baadc1f..abb3e8a 100644
--- a/build.gradle
+++ b/build.gradle
@@ -19,7 +19,7 @@ jar {
dependencies {
testCompile group: 'junit', name: 'junit', version: '4.12'
compile group: 'org.xerial', name: 'sqlite-jdbc', version: '3.7.2'

  • compile 'com.jfoenix:jfoenix:1.10.0'
  • compile 'com.jfoenix:jfoenix:9.0.2'
    compile 'de.jensd:fontawesomefx-fontawesome:4.7.0-5'
    compile 'com.gluonhq:charm-down-desktop:2.0.0'
    compile 'com.googlecode.json-simple:json-simple:1.1.1'
@goxr3plus
Copy link
Collaborator

goxr3plus commented Feb 23, 2018

Great i will do it! :)

I need some testing first.

@goxr3plus
Copy link
Collaborator

It's done :). You can download it for Java 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants