feat: add destroyed town-hall cost, require materials and stop city growth (until rebuilt)

[winex]

factorio-tycoon/construction-event-handler.lua

Lines 82 to 87 in fbbe87d

	if #nearby_town_hall == 0 then
	-- If there's no town hall in range then it probably was destroyed
	-- todo: how should we handle that situation? Is the whole city gone?
	-- probably in the "destroyed" event, because the player can't mine the town hall
	return
	end

just got an idea about this - i propose we:

• make town-hall "constructable" (not players) in the first place, so it needs to be finished in completeConstruction()
• stop any growing (or all!) activity for this city if town-hall was destroyed
• require some materials in HW stores to "reconstruct" town-hall
  stores might be destroyed by biters too, but they're already buildable / player-craftable

plus related:

• ? change roads to: dirt roads(???) -> stone bricks -> concrete (looks weird if no research and w/o such materials)
• increase initial city grid to 2x2 empty "cells", so we have a real-looking center, with a crossroad at least :)
• randomly place town-hall (and treasury probably) in one of that 4 cells

had some thoughts about city center vs town-hall as city center... city centers in real world are mostly thought as road Squares, not some building - so the tags are now be placed correctly, not at town-hall position.
proposed changes above will emphasize this...

[bahrmichael]

make town-hall "constructable" (not players) in the first place, so it needs to be finished in completeConstruction()

That's on my immediate to-do list :) There will be a recipe that we can use, and players can unlock the recipe when they research Multiple Cities. I plan on removing the urban planning center and its mechanics.

stop any growing (or all!) activity for this city if town-hall was destroyed

We can do that, if we allow it to be rebuilt early in the game.

require some materials in HW stores to "reconstruct" town-hall

I'm not sure about that yet. I plan on making the recipe relatively expensive. That means it would need a lot of space in hardware stores, and also how do we communicate to players what they need to rebuild it? This tbh feels more like a chore than nice gameplay.

[winex]

the point i was talking about - the destroyed-by-biters reason in the above on_removed() code, this could be independent of crafting-by-player and totally apart from Multiple Cities tech.

• city-constructable meant to be processed in City:: class, not by players
• buildable by players is being craftable or placeable

I'm not sure about that yet. I plan on making the recipe relatively expensive.

i mean recipe != constructionCost, the latter specified in Constants.CONSTRUCTION_MATERIALS and taken from HW stores to complete, while expensive recipe ingredients must be put in player or machine's inventories instead:

• HW stores <-- CONSTRUCTION_MATERIALS[name]
• inventory <-- recipe[name].ingredients

we're talking about 2 different things:

1. city with town-hall being invalid (destroyed, ghost, w/e), processing-wise from code perspective
2. craftable/replacable town-hall and it's entity-ghost if destroyed

[bahrmichael]

? change roads to: dirt roads(???) -> stone bricks -> concrete (looks weird if no research and w/o such materials)

That sounds like a nice idea! The city could then upgrade roads as it upgrades housing or as the city grows in size. Do you know of any tiles we can use as dirt roads?

[winex]

currently i know only dirt-{1..7} and landfill tiles - we can try these ones if that looks any better.
edit: found dry-dirt, looks great for roads. together with landfill under buildings should make map look better ;)

some mods adds more road types like asphalt from pyanodon, but i think that overall cross-mod interoperability should be avoided as much as possible, especially for entities, while tiles is the least problematic: i have some experience of installing and removing some mods in a single mp save -- it doesn't go very well and sometimes leads to mod-crashes

[bahrmichael]

increase initial city grid to 2x2 empty "cells", so we have a real-looking center, with a crossroad at least :)
randomly place town-hall (and treasury probably) in one of that 4 cells

I think I like the current design. Is there any reason to change this apart from asthetics?

[winex]

only 1 minor one, which cause i still couldn't get: city.roadEnds = { first = 6, last = 5 } #186 (comment) and we should fix that first, ofc :)