Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add GIFs for more fun #497

Open
HarshaVardhanNakkina opened this issue May 25, 2021 · 6 comments
Open

Feature request: Add GIFs for more fun #497

HarshaVardhanNakkina opened this issue May 25, 2021 · 6 comments

Comments

@HarshaVardhanNakkina
Copy link
Contributor

@baires Display a funny gifs/images below the reasons, to add more fun

@baires
Copy link
Owner

baires commented May 25, 2021

It could be fun, at some point I was looking into integrate with tenor api to get relevant gif for reason.
Feel free to open a PR with your ideas or Discussions to brainstorming

@HarshaVardhanNakkina
Copy link
Contributor Author

sending the whole reason as a tag/keyword to the gif API is not resulting in a relevant gif
I think maitaining a list of tags/keywords along with the reasons would be a good idea
what do you think?

@Brunomachadob
Copy link
Contributor

Brunomachadob commented Jun 14, 2021

That would be nice.

I didn't know about this Tenor service, we usually use https://giphy.com/ at work.
Not sure which one would provide a better API/embed options

As for how to select the GIF, I would say it would be better for each reason to have a list of GIFs URLs and then we could randomly select one of them before returning.

I like the idea of having the tags/keywords but the problem is the result could be too random, tomorrow someone uploads a GIF that has nothing to do with what we want, with one of our keywords and suddenly we are displaying it.

As the reasons are hardcoded, maybe the GIFs for each of them could also be.

@HarshaVardhanNakkina
Copy link
Contributor Author

I like the idea of having the tags/keywords but the problem is the result could be too random, tomorrow someone uploads a GIF that has nothing to do with what we want, with one of our keywords and suddenly we are displaying it.

As the reasons are hardcoded, maybe the GIFs for each of them could also be.

perfect

@HarshaVardhanNakkina
Copy link
Contributor Author

we can have URLs of selected gifs along with each reason, and randomly select one of them when displaying the corresponding reason

@HarshaVardhanNakkina
Copy link
Contributor Author

I just opened pull request for this #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants