-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Add GIFs for more fun #497
Comments
It could be fun, at some point I was looking into integrate with tenor api to get relevant gif for reason. |
sending the whole reason as a tag/keyword to the gif API is not resulting in a relevant gif |
That would be nice. I didn't know about this Tenor service, we usually use https://giphy.com/ at work. As for how to select the GIF, I would say it would be better for each reason to have a list of GIFs URLs and then we could randomly select one of them before returning. I like the idea of having the tags/keywords but the problem is the result could be too random, tomorrow someone uploads a GIF that has nothing to do with what we want, with one of our keywords and suddenly we are displaying it. As the reasons are hardcoded, maybe the GIFs for each of them could also be. |
perfect |
we can have URLs of selected gifs along with each reason, and randomly select one of them when displaying the corresponding reason |
I just opened pull request for this #526 |
@baires Display a funny gifs/images below the reasons, to add more fun
The text was updated successfully, but these errors were encountered: