Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dataclass instance check #507

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Improve dataclass instance check #507

merged 1 commit into from
Jul 9, 2024

Conversation

disrupted
Copy link
Member

@disrupted disrupted commented Jul 8, 2024 •
edited
Loading

Fixes a type error, because we need an instance of dataclass for the asdict function

@disrupted disrupted requested a review from raminqaf as a code owner July 8, 2024 17:43
@disrupted disrupted added the type/refactor Refactoring of existing functionality label Jul 8, 2024
@disrupted disrupted self-assigned this Jul 8, 2024
@disrupted disrupted merged commit a61de1b into main Jul 9, 2024
8 of 9 checks passed
@disrupted disrupted deleted the fix/is-dataclass-instance branch July 9, 2024 07:32
@DerTiedemann DerTiedemann mentioned this pull request Jul 12, 2024
Merged
@DerTiedemann DerTiedemann mentioned this pull request Jul 29, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raminqaf raminqaf raminqaf approved these changes

Assignees

@disrupted disrupted

Labels
type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disrupted @raminqaf