Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename role to label #525

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Rename role to label #525

merged 4 commits into from
Aug 14, 2024

Conversation

raminqaf
Copy link
Contributor

@raminqaf raminqaf commented Aug 12, 2024

@raminqaf raminqaf added type/refactor Refactoring of existing functionality breaking-change Indicates that this PR introduces a breaking change labels Aug 12, 2024
@raminqaf raminqaf self-assigned this Aug 12, 2024
@raminqaf raminqaf requested a review from disrupted as a code owner August 12, 2024 15:29
@raminqaf raminqaf requested a review from disrupted August 14, 2024 11:31
kpops/components/common/topic.py Outdated Show resolved Hide resolved
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, otherwise LGTM

@raminqaf raminqaf merged commit 3ab8885 into v8 Aug 14, 2024
9 checks passed
@raminqaf raminqaf deleted the feat/rename-role branch August 14, 2024 13:57
raminqaf added a commit that referenced this pull request Aug 21, 2024
raminqaf added a commit that referenced this pull request Aug 21, 2024
raminqaf added a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants