Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring pool creator #187

Closed
agualis opened this issue Nov 27, 2024 · 5 comments
Closed

Bring pool creator #187

agualis opened this issue Nov 27, 2024 · 5 comments

Comments

@agualis
Copy link
Collaborator

agualis commented Nov 27, 2024

Pool creator is an standalone project that is currently copy-pasting some of the code from V3 monorepo. We should:
A. Move the pool creator inside the mono-repo
or
B. Extract am npm library to share the common code that the current pool creator is duplicating.

@agualis agualis added the v3 label Nov 27, 2024
@agualis
Copy link
Collaborator Author

agualis commented Nov 27, 2024

cc @MattPereira

@MattPereira
Copy link
Member

Hey not currently copy pasting code from v3 monorepo since I haven't had time to hook up the user token wallet balances yet. Got tied up with other more critical issues

Open to moving pool creator into monorepo but you are aware the scaffold stack is nextjs / wagmi / viem / tanstack / tailwind / daisyui right?

@garethfuller
Copy link
Contributor

@MattPereira we're using Turborepo so having different dependencies won't be a problem. They'll just be dependencies of your app.

@MattPereira
Copy link
Member

MattPereira commented Nov 27, 2024

oh sweet then I guess decision comes down to if reward of moving scaffold into v3 monorepo is worth the trouble ?
( this is just me guessing 😅 )

Costs

  • Vercel deployment would need to be changed
  • Risk of additional complexity as scaffold itself is a yarn workspaces monorepo so may need some re-configuration?

Benefits

  • Scaffold could borrow things like rpc urls and react hooks from v3 FE?
  • Fewer balancer repos floating around

@garethfuller garethfuller removed the v3 label Nov 28, 2024
@garethfuller
Copy link
Contributor

I think eventually pool creation will be brought within the main app and the cost of managing another app within the monorepo for now isn't worth it. We can revisit this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants