-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring pool creator #187
Comments
cc @MattPereira |
Hey not currently copy pasting code from v3 monorepo since I haven't had time to hook up the user token wallet balances yet. Got tied up with other more critical issues Open to moving pool creator into monorepo but you are aware the scaffold stack is nextjs / wagmi / viem / tanstack / tailwind / daisyui right? |
@MattPereira we're using Turborepo so having different dependencies won't be a problem. They'll just be dependencies of your app. |
oh sweet then I guess decision comes down to if reward of moving scaffold into v3 monorepo is worth the trouble ? Costs
Benefits
|
I think eventually pool creation will be brought within the main app and the cost of managing another app within the monorepo for now isn't worth it. We can revisit this later. |
Pool creator is an standalone project that is currently copy-pasting some of the code from V3 monorepo. We should:
A. Move the pool creator inside the mono-repo
or
B. Extract am npm library to share the common code that the current pool creator is duplicating.
The text was updated successfully, but these errors were encountered: