TestDeltaCorrectness/delta-006-007 much slower than the others

[lmbarros]

The test case delta-006-007 (part of the TestDeltaCorrectness integration test) runs much slower than its sibling test cases, which do the same thing with different data. I don't why, but I don't think the different input data alone could explain the difference. Maybe we are hitting some performance corner case there?

--- PASS: TestDeltaCorrectness (28.07s)
    --- PASS: TestDeltaCorrectness/delta-000-001 (0.38s)
    --- PASS: TestDeltaCorrectness/delta-000-002 (0.50s)
    --- PASS: TestDeltaCorrectness/delta-001-003 (1.20s)
    --- PASS: TestDeltaCorrectness/delta-000-003 (0.99s)
    --- PASS: TestDeltaCorrectness/delta-004-005 (1.13s)
    --- PASS: TestDeltaCorrectness/delta-006-007 (15.43s)
    --- PASS: TestDeltaCorrectness/delta-006-008 (2.06s)
    --- PASS: TestDeltaCorrectness/delta-008-006 (1.89s)
    --- PASS: TestDeltaCorrectness/delta-010-011 (2.45s)
    --- PASS: TestDeltaCorrectness/delta-010-012 (1.93s)

[lmbarros]

I think the "delta-006-007" test case involves an image with much more layers than the other test cases, so this could be a reason. This needs to be confirmed, though. And, if confirmed, would be interesting to do some profiling to find the bottleneck and possibly get some good performance improvements.

[zoobot]

It looks like its possibly running twice and has an error:

22:58:29 ====  START TestDeltaCorrectness
22:58:29 ====  A Type of delta-006-007 is string=== RUN   TestDeltaCorrectness/delta-006-007

22:58:29 ====  0 Type of [006 007] is []string

22:58:29 ====  0 START ttrBuildImage
22:58:29 ====  2 ttrBuildImage after copy.DirCopy
22:58:29 ====  3 ttrBuildImage after imageBuild
22:58:32 ====  5 ttrBuildImage after read and close

22:58:32 ====  0 START ttrBuildImage
22:58:32 ====  2 ttrBuildImage after copy.DirCopy
22:58:33 ====  3 ttrBuildImage after imageBuild
22:58:36 ====  5 ttrBuildImage after read and close

22:58:36 ==== START ttrCreateDelta 

22:58:37 ==== END ttrCreateDelta 
22:58:38 ====  5 ttrRemoveImag
22:58:38 ==== 6 END ttrBuildImage 
22:58:38 ====  5 ttrRemoveImag
22:58:38 ==== END TestDeltaCorrectness



22:58:38 ====  5 ttrRemoveImag
22:58:38 ==== 6 END ttrBuildImage --- PASS: TestDeltaCorrectness (9.09s)
    --- PASS: TestDeltaCorrectness/delta-006-007 (8.95s)
PASS

=== Failed
=== FAIL: arm64.integration.image TestDeltaCorrectness (unknown)




22:58:29 ====  START TestDeltaCorrectness
22:58:29 ====  A Type of delta-006-007 is string=== RUN   TestDeltaCorrectness/delta-006-007

22:58:29 ====  0 Type of [006 007] is []string

22:58:29 ====  0 START ttrBuildImage
22:58:29 ====  2 ttrBuildImage after copy.DirCopy
22:58:29 ====  3 ttrBuildImage after imageBuild
22:58:32 ====  5 ttrBuildImage after read and close

22:58:32 ====  0 START ttrBuildImage
22:58:32 ====  2 ttrBuildImage after copy.DirCopy
22:58:33 ====  3 ttrBuildImage after imageBuild
22:58:36 ====  5 ttrBuildImage after read and close

22:58:36 ==== START ttrCreateDelta 

22:58:37 ==== END ttrCreateDelta 
22:58:38 ====  5 ttrRemoveImag
22:58:38 ==== 6 END ttrBuildImage 
22:58:38 ====  5 ttrRemoveImag
22:58:38 ==== END TestDeltaCorrectness



22:58:38 ====  5 ttrRemoveImag
22:58:38 ==== 6 END ttrBuildImage --- PASS: TestDeltaCorrectness (9.09s)
    --- PASS: TestDeltaCorrectness/delta-006-007 (8.95s)


DONE 1 tests, 1 failure in 30.898s
---> Making bundle: .integration-daemon-stop (in bundles/test-integration)
Removing test suite binaries
exiting test-integration
++ exit 0

[zoobot]

Building the image takes the most time.