Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI 'wrap' command needs to build smaller files. #164

Open
ballercat opened this issue Oct 14, 2018 · 1 comment
Open

CLI 'wrap' command needs to build smaller files. #164

ballercat opened this issue Oct 14, 2018 · 1 comment

Comments

@ballercat
Copy link
Owner

Problem

walt-cli package when linking multiple .walt files together can "wrap" the modules in a stand-alone JS module. The resulting module is too large because it serialized the dependency tree with the AST information encoded directly into the output, resulting in a massive amount of js.

Encoding the dependencies into the file is done to ensure the module can be used stand-alone in browser or node. Only the opcodes objects should be necessary for each module.

Goal

Patch the cli wrap function to result in a stripped down version of the modules (without AST information) which can still build but only include the bare minimum buffers in the resulting JS module.

Notes

@randy7d0
Copy link
Contributor

Assuming we strip off AST info from final JS file, how should we test to ensure there is no breakage of any sort. Some suggestions would help for a new person looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants