Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an entry in FAQ #874

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added an entry in FAQ #874

wants to merge 3 commits into from

Conversation

speco29
Copy link

@speco29 speco29 commented Jan 22, 2025 •
edited
Loading

fixes #802
Added the question regarding the interpret module.

Thank your for opening a PR!

Before you proceed, please check the following notes.

  • Make sure you describe the changes introduced in the PR.
  • If this PR addresses an existing issue, please mention it here.
  • Check our Guidelines for Contributing.
  • In particular, pay attention to the pull request checklist.
  • The most important points are to
    • Install all the needed requirements (requirements.txt, requirements-dev.txt, etc.)
    • Make sure all test pass.
    • Make sure your code passes black.
    • Make sure your code passes pylint.

@speco29
fixes bambinos#802
58db7ca 
Added an entry in FAQ
@speco29
fixes bambinos#437
d4e5d57 
Added piecewise regression example to example docs.
@speco29
Delete examples.py
3fbc8d9
GStechschulte
GStechschulte requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@GStechschulte GStechschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think adding question(s) about interpret is a good choice. This PR looks to be a duplicate of #881? If so, can we merge the two PRs?

docs/faq.qmd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a question about our interpret submodule. I think it is good.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I made another PR for adding interpret submodule question or this will work?

examples
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this was deleted?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That commit was made for some other issue, but as these commits were made in the same branch, it gets added here so i decided to delete it as it was creating a mess

@speco29
Copy link
Author

speco29 commented Jan 28, 2025

Thanks for the PR. I think adding question(s) about interpret is a good choice. This PR looks to be a duplicate of #881? If so, can we merge the two PRs?

I think its possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GStechschulte GStechschulte GStechschulte requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea for entry in our FAQ
2 participants
@speco29 @GStechschulte