Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Missing descriptions in locales/en/modifier-type.ts #1

Open
bannert1337 opened this issue May 30, 2024 · 1 comment
Open

Sweep: Missing descriptions in locales/en/modifier-type.ts #1

bannert1337 opened this issue May 30, 2024 · 1 comment
Labels
enhancement New feature or request sweep Sweep your software chores

Comments

@bannert1337
Copy link
Owner

Describe the bug
Some items seem to have missing descriptions in locales/en/modifier-type.ts

These include:

Grip Claw
Wide Lens
Multi lens
DNA splicers
Mini Black Hole

To Reproduce
I was just doing some localization and came across this.

They are there, under ContactHeldItemTransferChanceModifierType, PokemonMoveAccuracyBoosterModifierType, PokemonMultiHitModifierType, FusePokemonModifierType, and TurnHeldItemTransferModifierType, respectively. I agree that it is a bit confusing that they aren't marked as a "description" next to the item names, though.

@bannert1337 bannert1337 added the enhancement New feature or request label May 30, 2024
@sweep-ai sweep-ai bot added the sweep Sweep your software chores label May 30, 2024
Copy link

sweep-ai bot commented May 30, 2024

Sweeping

0%

Actions

  • ↻ Restart Sweep

❌ Unable to Complete PR

The issue was rejected with the following response:

Thank you for reporting this issue. However, it's a bit unclear what needs to be fixed based on the details provided. The last comment seems to indicate the descriptions are actually there, just not clearly labeled. If there is still an issue that needs to be resolved, please update the bug report with:

  1. The specific problem - are descriptions missing entirely or just mislabeled?
  2. The exact file(s) and line number(s) where the problem occurs
  3. What the fix should be - add missing descriptions, relabel existing ones, or something else?

Providing those details will help the development team better understand and resolve the issue. Let me know if you have any other questions!

For bonus Sweep issues, please report this bug on our community forum (tracking ID: bf1e13d9f2).


Tip

To recreate the pull request, edit the issue title or description.

This is an automated message generated by Sweep AI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sweep Sweep your software chores
Projects
None yet
Development

No branches or pull requests

1 participant