Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add X-Request-Start header #69

Closed
AxelTheGerman opened this issue Nov 17, 2024 · 1 comment
Closed

Request: Add X-Request-Start header #69

AxelTheGerman opened this issue Nov 17, 2024 · 1 comment

Comments

@AxelTheGerman
Copy link
Contributor

Love the new kamal-proxy and I know we want to keep it simple and not add too many features.

However, I was hoping - similar to X-Request-Id - we could add X-Request-Start header for all incoming requests. This would allow any downstream system to assess the queuing time, which is probably the most important metric the app itself cannot determine.

All major monitoring systems seem to support this header and pick it up automatically when it's set - skylight, datadog, new relic etc.

proxy_set_header X-Request-Start "t=${msec}";

For more context: https://pawelurbanek.com/rails-performance-fixes#eliminate-request-queue-time

I know that we could require users to run a separate proxy, but I'd argue that the simplicity of this should hopefully qualify for similar treatment as the request ID.

@kevinmcconnell
Copy link
Collaborator

Completely agree, @AxelTheGerman! Thanks for your suggestion and contribution.

Added in #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants