From 1694aad73a2899e293ec3238b914315f77fda1a6 Mon Sep 17 00:00:00 2001 From: platon Date: Tue, 16 Aug 2016 09:50:19 +0000 Subject: [PATCH 1/2] Set default framework role as a framework name --- src/rms_config.erl | 5 +++++ src/rms_sup.erl | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/rms_config.erl b/src/rms_config.erl index 679c92a..cec806e 100644 --- a/src/rms_config.erl +++ b/src/rms_config.erl @@ -25,6 +25,7 @@ constraints/0, zk/0, framework_name/0, + framework_role/0, webui_url/0, artifacts/0, artifact_urls/0, @@ -86,6 +87,10 @@ zk() -> framework_name() -> get_value(name, ?DEFAULT_NAME, string). +-spec framework_role() -> string(). +framework_role() -> + get_value(name, framework_name(), string). + -spec framework_hostname() -> string(). framework_hostname() -> case get_value(hostname, undefined, string) of diff --git a/src/rms_sup.erl b/src/rms_sup.erl index 1b1cd76..5da2f8b 100644 --- a/src/rms_sup.erl +++ b/src/rms_sup.erl @@ -91,7 +91,7 @@ init_rest() -> end || Node <- ZkNodes], FrameworkUser = rms_config:get_value(user, "root"), FrameworkName = rms_config:framework_name(), - FrameworkRole = rms_config:get_value(role, "riak", string), + FrameworkRole = rms_config:framework_role(), FrameworkHostname = rms_config:framework_hostname(), FrameworkPrincipal = rms_config:get_value(principal, "riak", string), FrameworkFailoverTimeout = From b1617aeeecd96c18eb7f2aa18d8dd17ee621fe80 Mon Sep 17 00:00:00 2001 From: platon Date: Tue, 16 Aug 2016 10:37:54 +0000 Subject: [PATCH 2/2] Change default hostname to name.marathon.mesos --- src/rms_config.erl | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/rms_config.erl b/src/rms_config.erl index cec806e..3bcdb1d 100644 --- a/src/rms_config.erl +++ b/src/rms_config.erl @@ -35,7 +35,7 @@ -export([get_value/2, get_value/3]). -define(DEFAULT_NAME, "riak"). --define(DEFAULT_HOSTNAME, "riak.mesos"). +-define(DEFAULT_HOSTNAME_SUFFIX, ".marathon.mesos"). -define(DEFAULT_MASTER, "master.mesos:5050"). -define(DEFAULT_ZK, "master.mesos:2181"). -define(DEFAULT_CONSTRAINTS, "[]"). @@ -95,13 +95,9 @@ framework_role() -> framework_hostname() -> case get_value(hostname, undefined, string) of undefined -> - {ok, LH} = inet:gethostname(), - case inet:gethostbyname(LH) of - {ok, {_, FullHostname, _, _, _, _}} -> - FullHostname; - _ -> ?DEFAULT_HOSTNAME - end; - HN -> HN + framework_name() ++ ?DEFAULT_HOSTNAME_SUFFIX; + Hostname -> + Hostname end. -spec webui_url() -> string().