Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assuming integer values for width/height #53

Open
tombakas opened this issue Oct 8, 2015 · 7 comments
Open

Assuming integer values for width/height #53

tombakas opened this issue Oct 8, 2015 · 7 comments
Assignees

Comments

@tombakas
Copy link

tombakas commented Oct 8, 2015

This prevents the users from entering percentages as values. Code from easy_maps/templatetags/easy_maps_tags.py:

...
options = Options(
        Argument('address', resolve=True, required=True),
        IntegerArgument('width', required=False, default=None),
        IntegerArgument('height', required=False, default=None),
        IntegerArgument('zoom', required=False, default=16),
        'using',
        Argument('template_name', default=None, required=False),
    )
...

I'd suggest turning these into Argument instances and adjusting the code in the html template accordingly.

@bashu bashu self-assigned this Oct 8, 2015
@alexeiramone
Copy link

I had the same issue and downgraded easy_maps in order to keep maps ok in the responsive template

@tombakas
Copy link
Author

tombakas commented Jul 4, 2016

Unfortunately, the project doesn't seem to be actively maintained.

On 4 July 2016 at 15:33, Alexei Martchenko [email protected] wrote:

I had the same issue and downgraded easy_maps in order to keep maps ok in
the responsive template


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#53 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABgcmc-3OVMLxzo-Jpvb-JcYGO8eV0qwks5qSP2BgaJpZM4GLNCm
.

bashu added a commit that referenced this issue Oct 10, 2016
@bashu
Copy link
Owner

bashu commented Oct 10, 2016

@tombakas not sure if this need, all you need is to override / extend default easy_maps/map.html, for example https://github.com/bashu/django-easy-maps/blob/develop/example/templates/easy_maps/responsive.html

@bashu
Copy link
Owner

bashu commented Oct 10, 2016

@alexeiramone see comment above, let me know if this helps or not

bashu added a commit that referenced this issue Nov 11, 2016
* release/0.9.3: (34 commits)
  bump version number
  fixed broken tests
  fixed broken ``example`` project
  added responsive map as example, ref #53
  better ``TemplateSyntaxError`` exception handling
  added missing tests requirements
  make sure test suite is working...
  Add Google Maps API key configuration
  Fix Google Maps API warning: SensorNotRequired
  add django 1.9
  fix typos in readme
  pep8 cleanup
  improved test suite
  Update .travis.yml
  Update .landscape.yaml
  Update README.rst
  Update README.rst
  Update README.rst
  Update manage.py
  fix backward compatibility with python 2
  ...
@bashu
Copy link
Owner

bashu commented Mar 29, 2019

@tombakas @alexeiramone feel free to reopen if it's still an issue

@aoulaa
Copy link

aoulaa commented Sep 7, 2021

for some reason it's not working #53 (comment)

@bashu bashu reopened this Sep 25, 2021
bashu added a commit that referenced this issue Oct 9, 2021
@bashu
Copy link
Owner

bashu commented Oct 9, 2021

@aoulaa how it does not working? can you check updated responsive.html template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants