Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour JSON #5

Open
christopherchiu opened this issue Aug 15, 2017 · 6 comments
Open

Tour JSON #5

christopherchiu opened this issue Aug 15, 2017 · 6 comments
Assignees
Milestone

Comments

@christopherchiu
Copy link
Contributor

christopherchiu commented Aug 15, 2017

{
  tourId,
  tourName,
  tourDuration,
  mapImagesList: []
  locations: [{
    name,
    summary,
    spiritualSignificance,
    googleMapsParameter,
    tasks: [{
      icon,
      text
    }]
  }]
}
@mattam
Copy link
Contributor

mattam commented Aug 15, 2017

Should the "spiritualSignificance" be generalized to some sort of general text information block? So you would have an array of the actual history of the location and the spiritual history of the location, and other text data.

generalInfomation: [
  {
     title: "History",
     content: "blah blah"
  },
  {
     title: "Spiritual History",
     content: "blah blah"
  }
]

History

blah blah

Spiritual History

blah blah

@mattam
Copy link
Contributor

mattam commented Aug 15, 2017

The "location" element might also have to be generalized out, because it's going to be a sibling to the "transition" element (in between A->B transitional/walking directions)

So maybe:

tourItems: [
  {
  type: "location",
  title: "Land's end",
  etc etc
  },
  {
  type: "transition",
  title: "Walking directions",
  content: "Here's how you walk there..."
  }
]

@christopherchiu
Copy link
Contributor Author

Google map parameters: #7

@christopherchiu
Copy link
Contributor Author

@mattam I think for the first version we won't be doing transitions

@christopherchiu
Copy link
Contributor Author

@mattam I have mixed thoughts about the generalization. On one hand it makes things more flexible, but on the other, it takes the look and feel away from our hands. E.g. if someone wanted to put tasks at the very top they could, but it might not look and feel great.

@janiceyip
Copy link
Contributor

janiceyip commented Aug 15, 2017

@mattam @christopherchiu would we assume that every location will have a "history" and a "spiritual history"? Because if that's the case, we should just have both. Otherwise, maybe:

information: [
  { 
  summary: "short blurb", 
  history: "short history",
  spiritualHistory: "short spiritual history"
  }
]

Unless, of course, every place will have a summary but not necessarily a (spiritual) history.

@christopherchiu christopherchiu modified the milestone: Sprint 1 Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants