Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Info with the SAPUI5 Download URL #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juancarlosrodriguezf
Copy link

Log Info with the SAPUI5 Download URL

Log Info with the SAPUI5 Download URL
Copy link
Owner

@bastilimbach bastilimbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 👍

Comment on lines 103 to 104
console.log(`SAPUI5 download URL: ${sapui5DownloadURL}`)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we combine this with the console log in line 109? e.g:

console.log(`Downloading SAPUI5 from ${sapui5DownloadURL}...`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants