promisify extractSAPUI5 in downloader-core #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Basti,
first of all thx for this amazing tool :-)
This PR is a suggestion to promisify the Downloader.extractSAPUI5 function in the sap-ui5-downloader-core.
That allows a caller not only to have a callback for intermediate extract steps (updateProgress callback) but also when you call it with the await statement it would actually wait until the zip file is fully extracted.
That's shouldn't touch any of the existing logic but add an additional feature to it and the "await downloader.extractSAPUI5" would actually wait until the zip is fully extracted.
Feel free to adjust my suggestion to your needs :-)
Kind regards
Thorsten