-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FYI - Gazelle for JS #546
Comments
@robfig, this might be a thing that |
Very interesting.. I'll open an issue with them. If I understand correctly, you've actually checked in the language module to the rules_sass repo, yet you can still it up to build a gazelle with that included? Very cool. |
That's correct. The goal was to have the plugin local to the |
Ah nice to see more plugins cropping up - I added support for js/ts with rules_nodejs: https://github.com/ecosia/bazel_rules_nodejs_contrib#build-file-generation |
I wonder also if it could be interesting to keep a list of plugins here also to make it easier for others to find them. |
@robfig This is cool. Thank you for sharing this! As @achew22 suggested, would you consider sharing this with the I think ideally, each rule set would have a Gazelle extension. I think those probably belong in rule repositories rather than in Gazelle itself, since the rule set authors are the most knowledgable on how their rules should be generated and used. I'm happy to review PRs for Gazelle API usage and Go readability, but I don't know enough about TypeScript or SASS for example to contribute anything substantive there. @Globegitter Thanks for linking that extension! Collecting a list of extensions is a good idea. I've opened #554 for this. |
Sounds good, I opened bazelbuild/rules_closure#394 to gauge their interest. If they don't want to maintain it, I'll just host it in a standalone repo. I'll open a PR to add it to the list you started once it's in shape. Thanks! |
Just wanted to share that I've successfully added a
js
language module to Gazelle to produce closure_js_library targets. I don't expect you'd want to merge it and take on the maintenance burden, but I figure you might find it interesting and maybe someone else finds it helpful.master...robfig:js
The text was updated successfully, but these errors were encountered: