Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make build pass with --incompatible_auto_exec_groups #963

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dzbarsky
Copy link
Contributor

I'm not sure about adding those toolchain params to the action helpers, we could make the test rules declare the toolchain dep instead?

@dzbarsky dzbarsky changed the title Make build pass with --incompatible_auto_exec_groups fix: Make build pass with --incompatible_auto_exec_groups Oct 13, 2024
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also flip incompatible_auto_exec_groups in our bazelrc here to prove it's green (and keep it that way?)

@alexeagle alexeagle self-assigned this Oct 15, 2024
@dzbarsky
Copy link
Contributor Author

shouldn't we also flip incompatible_auto_exec_groups in our bazelrc here to prove it's green (and keep it that way?)

Yep, makes sense, done. I didn't see other flag flips there and wasn't sure what the policy was.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 43f8b3e into bazel-contrib:main Oct 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants