Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the main repo mapping in BuildIntegrationTestCase #24329

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 14, 2024

Some get* methods worked with apparent repo names, others didn't, which is a hurdle to contributions in this area (as observed while working on #24328).

Some `get*` methods worked with apparent repo names, others didn't, which is a hurdle to contributions in this area (as observed while working on bazelbuild#24328).
@fmeum fmeum requested a review from Wyverald November 14, 2024 13:14
@fmeum fmeum marked this pull request as ready for review November 14, 2024 13:14
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 14, 2024
@iancha1992 iancha1992 added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Nov 14, 2024
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 15, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 15, 2024

@bazel-io fork 8.0.0

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 18, 2024
@fmeum fmeum deleted the label-parse-test branch November 18, 2024 10:30
fmeum added a commit to fmeum/bazel that referenced this pull request Nov 20, 2024
Some `get*` methods worked with apparent repo names, others didn't, which is a hurdle to contributions in this area (as observed while working on bazelbuild#24328).

Closes bazelbuild#24329.

PiperOrigin-RevId: 697548136
Change-Id: I24c3624875d1d1110ee8685656b88fffe3be6d95
(cherry picked from commit 9534199)
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2024
…4413)

Some `get*` methods worked with apparent repo names, others didn't,
which is a hurdle to contributions in this area (as observed while
working on #24328).

Closes #24329.

PiperOrigin-RevId: 697548136
Change-Id: I24c3624875d1d1110ee8685656b88fffe3be6d95 
(cherry picked from commit 9534199)

Closes #24347
@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 8.0.0 RC3. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=8.0.0rc3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants