Update doc for how to re-run an action with another RBE instance. #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL update the readme file to show how to re-run an action on another RBE instance. This CL also fix the flag conflict issue, for execute_action, one and only one of these two flags should be set: [--action_root=PATH|--digest=DIGEST].
mrahs
approved these changes
Aug 2, 2024
go/README.md
Outdated
Comment on lines
57
to
58
| permission to download actions from `FOO`, but lack of permission to don't have | ||
| the permission to execute an action with instance `FOO`). In this case, you want |
There was a problem hiding this comment.
Suggested change
| permission to download actions from `FOO`, but lack of permission to don't have | |
| the permission to execute an action with instance `FOO`). In this case, you want | |
| permission to download actions from `FOO`, but don't have | |
| the permission to execute that instance). In this case, you want |
go/pkg/tool/embeddedtool.go
Outdated
| log.Exitf("either specify --digest or --action_root, should not set both of them together.") | ||
| } | ||
| if inputDigest == "" && actionRoot == "" { | ||
| log.Exitf("either specify --digest or --action_root, at least one of these two flag must be set.") |
There was a problem hiding this comment.
Suggested change
| log.Exitf("either specify --digest or --action_root, at least one of these two flag must be set.") | |
| log.Exitf("either specify --digest or --action_root, one of these two flag must be set, but not both.") |
go/pkg/tool/embeddedtool.go
Outdated
| @@ -157,3 +159,13 @@ func getPathFlag() string { | |||
| } | |||
| return pathPrefix | |||
| } | |||
|
|
|||
| func validateActionRootAndDg() (string, string) { | |||
There was a problem hiding this comment.
nit: validate implies no return values, but validation can be expected as a side effect for a function that does return values.
Suggested change
| func validateActionRootAndDg() (string, string) { | |
| func inputDgAndActionRoot() (string, string) { |
This CL update the readme file to show how to re-run an action on another RBE instance. This CL also fix the flag conflict issue, for execute_action, one and only one of these two flags should be set: [--action_root=PATH|--digest=DIGEST].
mrahs
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL update the readme file to show how to re-run an action on another RBE instance.
This CL also fix the flag conflict issue, for execute_action, one and only one of these two flags should be set: [--action_root=PATH|--digest=DIGEST].