Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require data on cc_sysroot? #243

Open
keith opened this issue Sep 22, 2024 · 0 comments
Open

Require data on cc_sysroot? #243

keith opened this issue Sep 22, 2024 · 0 comments

Comments

@keith
Copy link
Member

keith commented Sep 22, 2024

With cc_sysroot it's valid to provide just something like this:

cc_sysroot(
    name = "sysroot",
    sysroot = "@sdk//:dir",
)

Without actually propagating the files to the actions that rely on this. As far as I can tell the expected use of this is actually do provide the data alongside this:

cc_sysroot(
    name = "sysroot",
    data = ["@sdk//:all_files"],
    sysroot = "@sdk//:dir",
)

Which makes me wonder if this should be required on the cc_sysroot macro to make it more clear what attribute is expected for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant