Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted markers #18

Open
MoffKalast opened this issue Aug 5, 2021 · 1 comment
Open

Inverted markers #18

MoffKalast opened this issue Aug 5, 2021 · 1 comment

Comments

@MoffKalast
Copy link

MoffKalast commented Aug 5, 2021

Just wondering, how viable would it be to invert the marker colours in terms of detection? Right now the markers are set up to be a large square of black with a little white in the middle which is not exactly optimal in terms of printer cartridges.

I suppose it would take a major refactor to even try and check if the detection quality is comparable with an inverted colour scheme, but I'm just interested if this was ever considered or tried.

@bbenligiray
Copy link
Owner

Most markers are designed with a white outer border, a black inner border and the coding inside this inner border (because we don't want to care about what the color of the surface that the marker will be placed on). So my point is that the largest component of the marker is light, the second largest component is dark, and the rest is mixed.

The detection algorithm for STag is designed to only detect darker quads contained within a lighter border (because that eliminates half of the non-marker candidates, and can be expected to halve the number of false positives). There are two ways to detect markers with inverted colors

  • Reverse the condition here
  • A much better alternative is to just invert the color of the image and use the original implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants