You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
In SDK we have a method that checks if a position is valid. But the "valid" is not defined precisely. For example, the SDK expects it to mean "position is set at least partially", while user-facing code like iterators assumes it means "values used in positions are in a valid range".
We must first define a separate function that checks the range (e.g. offset >= 0), and then find and update all the places that expect this condition to hold.
The quick fix would be to add a check to the positional iterator specifically.
Maybe we can distinguish between "initialized" and "valid", where "initialized" captures the idea that the driver set position information for the object, and "valid" captures the idea that the position is in-bounds for the enclosing file?
I'm not deeply attached to those particular words, but I do think it makes sense to give these names of some kind in the documentation.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In SDK we have a method that checks if a position is valid. But the "valid" is not defined precisely. For example, the SDK expects it to mean "position is set at least partially", while user-facing code like iterators assumes it means "values used in positions are in a valid range".
We must first define a separate function that checks the range (e.g.
offset >= 0
), and then find and update all the places that expect this condition to hold.The quick fix would be to add a check to the positional iterator specifically.
Related to bblfsh/python-client#172
The text was updated successfully, but these errors were encountered: