Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses https://github.com/bboozzoo/mconnect/issues/53 #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xxxserxxx
Copy link

This prevents the server from crashing when the mpris plugin tries to talk to devices that aren't (yet) connected.

On the one hand, server processes should be as robust as possible and try to recover; in that spirit, my patch prevents the server from segfaulting when a device isn't present. However, the root cause -- that the mpris plugin may be incorrectly propegating messages -- is not addressed. On the other-other hand, I don't know if it shouldn't be propegating messages; probably, the bestest, correctest fix would be to make mconnect smart enough to not try to send messages to devices that aren't connected, whether or not plugins ask for it, but that's a much bigger change. And, as I initially stated, philisophically, having servers that recover gracefully when they encounter error states is preferable, so this is at least a necessary, if not sufficient, fix.

This prevents the server from crashing when the mpris plugin tries to talk to devices that aren't (yet) connected.
@desiderantes
Copy link

I think this project ins unmaintained. Perhaps you should fork it?

@xxxserxxx
Copy link
Author

@desiderantes Yeah, it looks abandoned.

I am not a vala programmer, and don't have any interest in the language, so I don't want people using my fork with expectations that I'm going to be doing any maintenance. @grimpy seems to be keeping their fork up, though, and their's is what I'm using as "upstream" for now. I've been sending patches here mainly because Arch's AUR mconnect points here.

@grimpy
Copy link

grimpy commented Jun 8, 2021

Same for me i kindof scrapped a bunch of patches together implemented a few things i personally use for me it's currentpy in a "it works for me status"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants