Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoise get functions for caching within session #4

Open
ateucher opened this issue Dec 21, 2018 · 1 comment · May be fixed by #231
Open

Memoise get functions for caching within session #4

ateucher opened this issue Dec 21, 2018 · 1 comment · May be fixed by #231
Labels
enhancement New feature or request wontfix This will not be worked on
Milestone
v0.2.0

Comments

@ateucher
Copy link
Collaborator

No description provided.

@stephhazlitt stephhazlitt added the enhancement New feature or request label Dec 21, 2018
boshek added a commit that referenced this issue Jan 24, 2019
@boshek
adding memoisation to geo_data. #4
29a23fa
@ateucher
Copy link
Collaborator Author

ateucher commented Mar 18, 2019 •
edited
Loading

This is difficult to implement when parsing filter expressions in bcdcget_geo_data(x, ...)

I had to take it out for now because memoization forces evaluation of its arguments, so it fails before it can parse the filter expressions into CQL. Eg.,:

bcdc_get_geodata("bc-major-cities-points-1-2-000-000-digital-baseline-mapping", 
                               POP_2000 < 1000)

because there is no object called POP_2000 so when that argument is evaluated it throws an error.

@ateucher ateucher added this to the v0.2.0 milestone Mar 18, 2019
@ateucher ateucher mentioned this issue Mar 18, 2019
Merged
5 tasks
@ateucher ateucher added the wontfix This will not be worked on label Mar 29, 2019
ateucher added a commit that referenced this issue Oct 23, 2020
@ateucher
memoise collect(), #4
fe6244e
@ateucher ateucher reopened this Oct 23, 2020
@ateucher ateucher linked a pull request Oct 23, 2020 that will close this issue
Draft
ateucher added a commit that referenced this issue Oct 23, 2020
@ateucher
Implement caching on disk, with a timeout and a forget function to cl…
d83cc3a 
…ear the cache. #4
ateucher added a commit that referenced this issue Oct 23, 2020
@ateucher
Add caching options, #4
2db02de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

In-session caching bcgov/bcdata
2 participants
@ateucher @stephhazlitt