Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a CAS user, I want to define the charges associated with each fuel defined in the Carbon Tax Act #431

Closed
4 tasks done
dleard opened this issue Mar 17, 2022 · 5 comments
Assignees

Comments

@dleard
Copy link
Contributor

dleard commented Mar 17, 2022

Description:

CAS users should be able to add/edit the fuel charges for each CTA fuel via a UI. This would be changing data in the ggircs_parameters.fuel_charge table. The UI for this can re-use some aspects of the un-mapped fuels component.

Acceptance Criteria:

Given I am logged in to the ggircs app
When I am on the landing page
Then I can navigate to a CTA management page
And I can see a selectable list of the CTA fuels on the left side of the screen

Given I am in the CTA management UI
When I select a CTA fuel type
Then I can see the related fuel charges and tax periods for that fuel

Given I am in the CTA management UI
When I need to add a fuel charge for an upcoming reporting year
Then I can add fuel charge data for that year

Given I am in the CTA management UI
When I need to edit a fuel charge
Then I can edit fuel charge data

Development Checklist:

  • user can navigate to a CTA management page
  • fuel charge data can be edited
  • new fuel charge data can be added (ie: for upcoming reporting years)
  • dates cannot overlap when adding/editing rate periods
@dleard
Copy link
Contributor Author

dleard commented Mar 17, 2022

@dleard
Copy link
Contributor Author

dleard commented Apr 29, 2022

@LindsayMacfarlane
To test this:

  • go to the ggircs app (dev)
  • log in with your idir and from the dashboard click Manage tax rates for carbon-taxed fuels
  • from there you should be able to select fuel types on the left and edit/create rate periods on the right
    Let me know if you'd like to go over this together

@LindsayMacfarlane
Copy link

Thanks @dleard! I appreciate the instructions :) Perhaps I don't have the needed permissions as I'm not able to select (or see) any fuel types in order to edit/create rate periods (see screenshot).
image.png

@dleard
Copy link
Contributor Author

dleard commented May 2, 2022

Ah, yes that's because of the issue here in #430, which could really be a bug rather than tech debt I suppose. The permissions are not in sync with the database being dropped in dev. I cycled the pod and you should be able to see fuels now.

@LindsayMacfarlane
Copy link

Perfect - thank you! Tested in dev by:

  • Updated period end date for Aviation fuel
  • Added a new rate period for Coke Oven Gas (got expected error message if there was an overlap in period dates); able to add a new rate period.

This was really intuitive to use!

Meets acceptance criteria. Thanks for all your work on this one @dleard

@dleard dleard closed this as completed May 13, 2022
@Dianadec Dianadec added this to the CIIP: FY 2022/2023 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants