Josh/step4 #12
Josh/step4 #12
Conversation
| return ( | ||
| <div className="App"> | ||
| <header className="App-header"> | ||
| <p>{data.allTasks.edges[0].node}</p> |
There was a problem hiding this comment.
I believe by this step, App should render your TodoList component because that's what contains all the todos at this point (also, if you want to make it clearer which work is part of which step, you can set the base branch for this branch to the one you used for step 3)
| import Card from "@mui/material/Card"; | ||
| import CardContent from "@mui/material/CardContent"; | ||
| import { Grid } from "@mui/material"; |
There was a problem hiding this comment.
FYI, when possible, we use components from this library: https://github.com/button-inc/service-development-toolkit. There's a bcgov theme that has colours, fonts, etc. built in, and progressive enhancement
| import { Grid } from "@mui/material"; | ||
|
|
||
| interface Props { | ||
| query: any; |
| ); | ||
|
|
||
| console.log(data.allTasks); | ||
| const listItems = data.allTasks.edges.map((todo: { node: { id: any; }; }) => |
There was a problem hiding this comment.
We try to avoid the any type (but nice work including typing)
| "storageKey": null | ||
| } | ||
| ], | ||
| "type": "Task", |
There was a problem hiding this comment.
This is where the Task type comes from, and it's coming from the column named "task" in the table
| -- requires: todo_appschema | ||
| -- requires: tasks | ||
|
|
||
| BEGIN; |
| BEGIN; | ||
|
|
||
| -- XXX Add verifications here. | ||
| SELECT id, task, completed, date_created, date_updated |
There was a problem hiding this comment.
If I remember correctly, verify only fails if there's an error. This won't error if the seed data went in wrong; it'll just return nothing. In this case, you could check that the count is greater than 0 or something (however, this one's not super relevant to our projects; we verify functions, tables, etc. but not seed data, and we usually check for existence)
| BEGIN; | ||
|
|
||
| -- XXX Add verifications here. | ||
| SELECT id, task, completed, date_created, date_updated |
Completed step 4 of the onboarding todo app