updates based on review feedback

bcgov · Dec 6, 2024 · 68f8216 · 68f8216
1 parent c9a0110
commit 68f8216
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -34,7 +34,7 @@ jobs:
       - name: Change directory to Angular app
         run: cd client/wfprev-war/src/main/angular
 
-      # Use the NPMRC secret to set up npm authenticationq
+      # Use the NPMRC secret to set up npm authentication
       - name: Add .npmrc file
         run: echo -e $NPMRC > ~/.npmrc
 

diff --git a/client/wfprev-war/src/main/angular/.github/test.yml b/client/wfprev-war/src/main/angular/.github/test.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         node-version: [20.x]
-  
+
     steps:
       - uses: actions/checkout@v4
 
@@ -21,8 +21,8 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
 
-      - run: npm install --legacy-peer-deps
-      
+      - run: npm install
+
       - run: npm run test -- --watch=false --code-coverage
 
       # Ensure coverage meets the required threshold
@@ -33,4 +33,4 @@ jobs:
           else
             echo "Code coverage is less than 80%!";
             exit 1;
-          fi
+          fi
diff --git a/server/wfprev-api/src/test/java/ca/bc/gov/nrs/wfprev/ProjectBoundaryControllerTest.java b/server/wfprev-api/src/test/java/ca/bc/gov/nrs/wfprev/ProjectBoundaryControllerTest.java
@@ -252,13 +252,13 @@ void testUpdateProjectBoundary_BadRequest() throws Exception {
         String json = mapper.writeValueAsString(project);
 
         // Test update
-        ResultActions resuult = mockMvc.perform(put("/projectBoundaries/{id}", "unmatched-id")
+        ResultActions result = mockMvc.perform(put("/projectBoundaries/{id}", "unmatched-id")
                         .content(json)
                         .contentType(MediaType.APPLICATION_JSON)
                         .header("Authorization", "Bearer admin-token")
                         .header("If-Match", "\"1\""))
                 .andExpect(status().isBadRequest());
-        assertEquals(400, resuult.andReturn().getResponse().getStatus());
+        assertEquals(400, result.andReturn().getResponse().getStatus());
     }
 
     @Test