Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-1260 add Outcome Date filter #110

Merged
merged 3 commits into from
Dec 9, 2024
Merged

feat: CE-1260 add Outcome Date filter #110

merged 3 commits into from
Dec 9, 2024

Conversation

Scarlett-Truong
Copy link
Collaborator

@Scarlett-Truong Scarlett-Truong commented Dec 4, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

action_type_action_xref_guid: xrefResult.action_type_action_xref_guid,
action_date: {
gte: new Date(startDate),
lte: endDate !== "undefined" ? new Date(endDate) : new Date(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be newUtcDate()?

Right now if I create an outcome for today, I can't bring it up in the search filter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@afwilcox afwilcox added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 185e847 Dec 9, 2024
9 checks passed
@afwilcox afwilcox deleted the feat/CE-1260 branch December 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants