From 7ba1894719725784d66b95a0d9a6556d912a174c Mon Sep 17 00:00:00 2001 From: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> Date: Thu, 7 Nov 2024 13:49:06 -0800 Subject: [PATCH] chore(fe): removed feature flag related to the search (#1304) * chore(fe): removed feature flag related to the search * test: fix VITE_GREEN_DOMAIN --------- Co-authored-by: Fernando Terra --- frontend/openshift.configmap.dev.yml | 2 +- frontend/openshift.configmap.test.yml | 2 +- frontend/package.json | 6 +++--- frontend/src/components/MainHeaderComponent.vue | 3 +-- frontend/src/routes.ts | 1 - 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/frontend/openshift.configmap.dev.yml b/frontend/openshift.configmap.dev.yml index 3559560ea5..edd1423759 100644 --- a/frontend/openshift.configmap.dev.yml +++ b/frontend/openshift.configmap.dev.yml @@ -22,4 +22,4 @@ objects: name: ${NAME}-${ZONE}-${COMPONENT}-config data: params.js: | - window.localStorage.setItem('VITE_FEATURE_FLAGS','{"STAFF_SEARCH":true}'); + window.localStorage.setItem('VITE_FEATURE_FLAGS','{}'); diff --git a/frontend/openshift.configmap.test.yml b/frontend/openshift.configmap.test.yml index 3559560ea5..edd1423759 100644 --- a/frontend/openshift.configmap.test.yml +++ b/frontend/openshift.configmap.test.yml @@ -22,4 +22,4 @@ objects: name: ${NAME}-${ZONE}-${COMPONENT}-config data: params.js: | - window.localStorage.setItem('VITE_FEATURE_FLAGS','{"STAFF_SEARCH":true}'); + window.localStorage.setItem('VITE_FEATURE_FLAGS','{}'); diff --git a/frontend/package.json b/frontend/package.json index 7b9b32b54f..e5fcf2507a 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -24,7 +24,7 @@ "scripts": { "start": "vite --host --port 3000", "build": "vue-tsc --noEmit && vite build", - "preview": "cross-env VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com VITE_FEATURE_FLAGS={\\\"STAFF_SEARCH\\\":true} start-server-and-test stub http://127.0.0.1:8080 start", + "preview": "cross-env VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com start-server-and-test stub http://127.0.0.1:8080 start", "preview:app": "cross-env VITE_NODE_ENV=test vite --host --port 3000", "typecheck": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false", "lint": "eslint . --fix --ignore-path .gitignore", @@ -36,12 +36,12 @@ "posttest:component": "mv reports/.nyc_report reports/component", "test:unit": "cross-env VITE_NODE_ENV=test NODE_ENV=test vitest run --coverage", "posttest:unit": "mv reports/.vite_report reports/unit", - "test:e2e": "cross-env VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com VITE_FEATURE_FLAGS={\\\"STAFF_SEARCH\\\":true} start-server-and-test preview http://127.0.0.1:3000 'cypress run --headless'", + "test:e2e": "cross-env VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com start-server-and-test preview http://127.0.0.1:3000 'cypress run --headless'", "posttest:e2e": "mv reports/.nyc_report reports/e2e", "pretest:report:merge": "rm -rf reports-merge && mkdir -p reports-merge && for name in component e2e unit; do cp reports/$name/coverage-final.json reports-merge/$name.json; done", "test:report:merge": "mkdir -p .nyc_output && rm -rf coverage && nyc --config nyc.config.json merge reports-merge && mv coverage.json .nyc_output/out.json && nyc --config nyc.config.json report --reporter lcov --reporter text-summary --report-dir coverage --temp-dir .nyc_output", "test:report:clean": "rm -rf reports && mkdir -p reports/.nyc_output/processinfo && mkdir -p coverage", - "test:build": "cross-env VITE_MODE=test VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com VITE_FEATURE_FLAGS={\\\"STAFF_SEARCH\\\":true} start-server-and-test preview http://127.0.0.1:3000 'cypress open'", + "test:build": "cross-env VITE_MODE=test VITE_NODE_ENV=test VITE_GREEN_DOMAIN=green-domain.com start-server-and-test preview http://127.0.0.1:3000 'cypress open'", "test:flush": "rm -rf reports && rm -rf .nyc_output && rm -rf coverage && rm -rf reports-merge", "posttest:flush": "npm run coverage", "test:unit:devtools": "cross-env VITE_NODE_ENV=test NODE_ENV=test vitest run --inspect-brk --pool threads --poolOptions.threads.singleThread" diff --git a/frontend/src/components/MainHeaderComponent.vue b/frontend/src/components/MainHeaderComponent.vue index 95543d827e..14decf43e4 100644 --- a/frontend/src/components/MainHeaderComponent.vue +++ b/frontend/src/components/MainHeaderComponent.vue @@ -252,8 +252,7 @@ const handleLogoutClick = (event) => { Client search diff --git a/frontend/src/routes.ts b/frontend/src/routes.ts index 4c8ef562f3..f05362c753 100644 --- a/frontend/src/routes.ts +++ b/frontend/src/routes.ts @@ -200,7 +200,6 @@ export const routes = [ style: "content-stretched", headersStyle: "headers-compact", sideMenu: true, - featureFlagged: "STAFF_SEARCH", profile: true, }, },