From c74e923e2a7f376fb75ffbf5b24f718fb9803c18 Mon Sep 17 00:00:00 2001 From: Maria Martinez Date: Tue, 21 Nov 2023 14:41:12 -0800 Subject: [PATCH] fix: Fixed code smell issues --- .../bc/gov/app/dto/client/ClientBusinessInformationDto.java | 4 ++-- .../app/validator/client/ClientSubmitRequestValidator.java | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/backend/src/main/java/ca/bc/gov/app/dto/client/ClientBusinessInformationDto.java b/backend/src/main/java/ca/bc/gov/app/dto/client/ClientBusinessInformationDto.java index 7d232255a9..781a243f5c 100644 --- a/backend/src/main/java/ca/bc/gov/app/dto/client/ClientBusinessInformationDto.java +++ b/backend/src/main/java/ca/bc/gov/app/dto/client/ClientBusinessInformationDto.java @@ -26,8 +26,8 @@ public Map description() { "clientType", StringUtils.isBlank(clientType) ? "" : clientType, "goodStanding", StringUtils.isBlank(goodStandingInd) ? "" : goodStandingInd, "legalType", StringUtils.isBlank(legalType) ? "" : legalType, - "birthdate", Optional.ofNullable(birthdate).isPresent() ? - birthdate : LocalDate.of(1975, 1, 31) + "birthdate", Optional.ofNullable(birthdate).isPresent() + ? birthdate : LocalDate.of(1975, 1, 31) ); } } diff --git a/backend/src/main/java/ca/bc/gov/app/validator/client/ClientSubmitRequestValidator.java b/backend/src/main/java/ca/bc/gov/app/validator/client/ClientSubmitRequestValidator.java index 207c61afd8..921c28dac7 100644 --- a/backend/src/main/java/ca/bc/gov/app/validator/client/ClientSubmitRequestValidator.java +++ b/backend/src/main/java/ca/bc/gov/app/validator/client/ClientSubmitRequestValidator.java @@ -3,7 +3,6 @@ import static ca.bc.gov.app.util.ClientValidationUtils.fieldIsMissingErrorMessage; import ca.bc.gov.app.ApplicationConstant; - import ca.bc.gov.app.dto.client.BusinessTypeEnum; import ca.bc.gov.app.dto.client.ClientBusinessInformationDto; import ca.bc.gov.app.dto.client.ClientLocationDto;