Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSADT1-1035] Good standing is not showing as TRUE #660

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[FSADT1-1035] Good standing is not showing as TRUE #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f57a5f4
fix: replace goodStanding with goodStandingInd
fterra-encora Dec 6, 2023
1fcc989
Merge branch 'main' into fix/FSADT1-1035
paulushcgcj Dec 7, 2023
52016a1
fix: display the Unknown standing notification
fterra-encora Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/dto/CommonTypesDto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export interface SubmissionDetailsBusiness {
clientNumber: string
organizationName: string
clientType: string
goodStanding: string
goodStandingInd: string
}

export interface SubmissionDetailsContact {
Expand Down
11 changes: 7 additions & 4 deletions frontend/src/pages/SubmissionReviewPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const data = ref<SubmissionDetails>({
clientNumber: '',
organizationName: '',
clientType: '',
goodStanding: '',
goodStandingInd: '',
},
contact: [{index:0, firstName:'', lastName:'', contactType:'', phoneNumber:'', emailAddress:'', locations:[],userId:''}],
address: [],
Expand All @@ -73,7 +73,6 @@ const rejectReasonMessage = ref('')
// Data loading
useFetchTo(`/api/clients/submissions/${id.value}`, data)


const showClientNumberField = computed(() => {
if(selectedRejectReasons.value && selectedRejectReasons.value.length > 0){
return selectedRejectReasons
Expand Down Expand Up @@ -243,7 +242,11 @@ const tagColor = (status: string) =>{
</cds-inline-notification>

<cds-actionable-notification
v-if="data.submissionType === 'Review new client' && !data.matchers.goodStanding && data.submissionStatus !== 'Approved'"
v-if="
data.submissionType === 'Review new client' &&
data.matchers.goodStanding === 'Value not found' &&
data.submissionStatus !== 'Approved'
"
v-shadow="true"
low-contrast="true"
hide-close-button="true"
Expand Down Expand Up @@ -311,7 +314,7 @@ const tagColor = (status: string) =>{
</read-only-component>

<read-only-component label="B.C. Registries standing">
<span class="body-compact-01">{{ goodStanding(data.business.goodStanding) }}</span>
<span class="body-compact-01">{{ goodStanding(data.business.goodStandingInd) }}</span>
</read-only-component>

<read-only-component label="Last updated">
Expand Down
Loading