Skip to content

Commit

Permalink
Pass pr number as TAG
Browse files Browse the repository at this point in the history
  • Loading branch information
DerekRoberts committed Oct 8, 2024
1 parent e2ef5b0 commit 44fa4f7
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
oc_token: ${{ secrets.OC_TOKEN }}
overwrite: ${{ matrix.overwrite }}
parameters:
-p ZONE=test
-p ZONE=test -p TAG=${{ needs.vars.outputs.pr }}
-p S3_SECRETKEY=${{ secrets.S3_SECRETKEY }}
${{ matrix.parameters }}
verification_path: ${{ matrix.verification_path }}
Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
oc_token: ${{ secrets.OC_TOKEN }}
overwrite: ${{ matrix.overwrite }}
parameters:
-p ZONE=prod
-p ZONE=prod -p TAG=${{ needs.vars.outputs.pr }}
-p S3_SECRETKEY=${{ secrets.S3_SECRETKEY }}
${{ matrix.parameters }}
verification_path: ${{ matrix.verification_path }}
Expand Down
5 changes: 4 additions & 1 deletion backend/openshift.deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ parameters:
- name: ZONE
description: Deployment zone, e.g. pr-### or prod
required: true
- name: TAG
description: Image tag; e.g. PR number, latest or prod
required: true
- name: DOMAIN
value: apps.silver.devops.gov.bc.ca
- name: CPU_REQUEST
Expand Down Expand Up @@ -113,7 +116,7 @@ objects:
deployment: "${NAME}-${ZONE}-${COMPONENT}"
spec:
containers:
- image: ${REGISTRY}/${ORG}/${NAME}/${COMPONENT}:${ZONE}
- image: ${REGISTRY}/${ORG}/${NAME}/${COMPONENT}:${TAG}
imagePullPolicy: Always
name: "${NAME}"
env:
Expand Down
5 changes: 4 additions & 1 deletion frontend/openshift.deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ parameters:
- name: ZONE
description: Deployment zone, e.g. pr-### or prod
required: true
- name: TAG
description: Image tag; e.g. PR number, latest or prod
required: true
- name: DOMAIN
value: apps.silver.devops.gov.bc.ca
- name: CPU_REQUEST
Expand Down Expand Up @@ -66,7 +69,7 @@ objects:
deployment: "${NAME}-${ZONE}-${COMPONENT}"
spec:
containers:
- image: ${REGISTRY}/${ORG}/${NAME}/${COMPONENT}:${ZONE}
- image: ${REGISTRY}/${ORG}/${NAME}/${COMPONENT}:${TAG}
securityContext:
capabilities:
add: ["NET_BIND_SERVICE"]
Expand Down

0 comments on commit 44fa4f7

Please sign in to comment.