New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2-3187 - Disallow non-numeric characters in transaction ID field on refund screen #1712

Open

glen-aot wants to merge 3 commits into main from ORV2-3187

+38 −1

Collaborator

glen-aot commented Dec 11, 2024 •

edited by github-actions bot

Loading

Description

Update transaction id input on refund screen to only accept numeric characters up to a max length of 15

Fixes #ORV2-3187

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist

I have read the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

Analysis Workflow

After merge, new images are promoted to:

Merge Workflow

glen-aot added 2 commits

December 11, 2024 15:08


          update transaction id input to only accept numeric characters up to a…

02f260c

… max length of 20


          reduce max transaction id length to 15

glen-aot requested review from krishnan-aot and zgong-gov as code owners

December 11, 2024 23:35

glen-aot temporarily deployed to dev

December 11, 2024 23:37

— with

GitHub Actions Inactive

krishnan-aot reviewed

View reviewed changes

frontend/src/features/permits/pages/Refund/RefundPage.tsx

+                const filterNonNumericValue = (input?: string) => {
+                  if (!input) return "";
+                  // only allows 0-9 inputs
+                  return input.replace(/[^\d]/g, "");

Collaborator

krishnan-aot Dec 12, 2024

Is this correct? you're just removing anything non-digit from the input. Shouldn't you display an error message asking the user to correct their input instead of just deleting non-numeric characters in their input?

Collaborator Author

glen-aot Dec 12, 2024

@krishnan-aot during todays dev sync Michael has confirmed that we are okay with this behavior - an error message pertaining to non-numeric values may be implemented in the future


          Merge branch 'main' into ORV2-3187

cab4948

glen-aot temporarily deployed to dev

December 12, 2024 22:40

— with

GitHub Actions Inactive

sonarcloud bot commented Dec 12, 2024

Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud bot commented Dec 12, 2024

Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud bot commented Dec 12, 2024

Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud bot commented Dec 12, 2024

Quality Gate passed for 'onroutebc_scheduler'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud bot commented Dec 12, 2024

Quality Gate failed for 'onroutebc frontend'

Failed conditions
22.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet