fix: test to verify kc idp hint

bcgov · Dec 6, 2024 · 94b4d4c · 94b4d4c
1 parent 41e184c
commit 94b4d4c
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/.../main/java/com/github/bcgov/keycloak/authenticators/browser/IdentityProviderStopForm.java b/.../main/java/com/github/bcgov/keycloak/authenticators/browser/IdentityProviderStopForm.java
@@ -51,20 +51,20 @@ public void authenticate(AuthenticationFlowContext context) {
       }
     }
 
-    String hintIdp = "";
-
     if (context.getUriInfo().getQueryParameters().containsKey(AdapterConstants.KC_IDP_HINT)) {
-      hintIdp = context.getUriInfo().getQueryParameters().getFirst(AdapterConstants.KC_IDP_HINT);
+      String hintIdp = context.getUriInfo().getQueryParameters().getFirst(AdapterConstants.KC_IDP_HINT);
+      if (hintIdp != null && !hintIdp.equals("") && idpContext.containsKey(hintIdp)) {
+        context.attempted();
+        return;
+      }
     }
 
-    // if only one IDP is enabled or hint IDP is passed, skip the form
-    if (!idpContext.isEmpty() && idpContext.size() == 1 && hintIdp != "") {
+    // if only one IDP is enabled then skip the form
+    if (!idpContext.isEmpty() && idpContext.size() == 1) {
       context.attempted();
       return;
     }
 
-    log.infof("hint idp: %s", hintIdp);
-
     MultivaluedMap<String, String> formData = new MultivaluedHashMap<>();
 
     try {