Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature Request: Integrate Missing Rhinestone Smart Session Policies #127

Open
1 task done
joepegler opened this issue Nov 24, 2024 · 0 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@joepegler
Copy link
Collaborator

Feature or Improvement Description

Integrate the following Rhinestone Smart Session policies that are currently not implemented: - Sudo Policy (unrestricted access for specified target/selector) - Spending Limits Policy (ERC20 token spending limits) - Usage Limit Policy (restrict number of times a session can be used) - Value Limit Policy (native token spending limits)

Benefits & Outcomes

  • Enhanced Security: Provide more granular control over session permissions
  • Better UX: Allow users to set appropriate limits for different use cases
  • Flexibility: Support different types of restrictions for different scenarios
  • Completeness: Implement full range of available Rhinestone policies
  • Risk Management: Enable users to limit potential exposure

Implementation Ideas

How

  1. Add Policy Implementations

    • Import policy helpers from Rhinestone SDK
    • Add policy type definitions
    • Implement policy creation functions
    • Add policy validation logic
  2. Update Session Creation

    • Extend session creation to support new policies
    • Add policy combination logic
    • Update policy encoding/decoding
  3. Update Types

    • Add new policy type definitions
    • Update session types to include new policies
    • Add policy configuration interfaces
  4. Add Validation

    • Validate policy parameters
    • Check policy combinations
    • Verify policy limits
  5. Update Documentation

    • Document new policy options
    • Add usage examples
    • Update type documentation
    • Add policy combination guidelines
  6. Add Tests

    • Test individual policies
    • Test policy combinations
    • Test validation logic
    • Test error cases

References

Any References?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@joepegler joepegler added the enhancement New feature or request label Nov 24, 2024
@joepegler joepegler self-assigned this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant