Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature Request: Add Test Suite for Multiple third party signers #128

Open
1 task done
joepegler opened this issue Nov 24, 2024 · 0 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@joepegler
Copy link
Collaborator

joepegler commented Nov 24, 2024

Feature or Improvement Description

Add comprehensive test cases demonstrating integration with different signer types, starting with ethers.js Signer. This will provide clear examples of how to use various signer implementations with the SDK.

Benefits & Outcomes

  • Better Documentation: Provide practical examples of integrating different signer types
  • Improved Developer Experience: Make it easier for developers to use their preferred signer library
  • Compatibility Verification: Ensure the SDK works correctly with popular signer implementations
  • Reduced Support Issues: Prevent common integration problems through clear examples
  • Framework Flexibility: Demonstrate SDK's ability to work with different Web3 frameworks

Implementation Ideas

  1. Create New Test File

    • Structure tests by signer type
    • Include setup and teardown for each signer type
  2. Common Scenarios to Test

Image

  1. Test Environment Setup

    • Add necessary test utilities
    • Create mock providers
    • Set up test accounts
    • Configure test networks
  2. Documentation

    • Add detailed comments explaining signer setup
    • Document any signer-specific considerations
    • Include example snippets in docs
    • Add troubleshooting notes
  3. Future Expansion

    • Structure tests to easily add more signer types
    • Consider hardware wallet integration tests
    • Add multi-signer scenario tests

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@joepegler joepegler added the enhancement New feature or request label Nov 24, 2024
@joepegler joepegler self-assigned this Nov 24, 2024
@joepegler joepegler changed the title ✨ Feature Request: Add Test Suite for Multiple Signer Types Integration ✨ Feature Request: Add Test Suite for Multiple third party signers Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant