TypeError: __init__() got an unexpected keyword argument 'debug'

[yuriiz]

Documentation on pypi and github says it should be instantiated like this:

SMTPServer(
    self,
    ('0.0.0.0', 465),
    None,
    require_authentication=True,
    ssl=True,
    certfile='examples/server.crt',
    keyfile='examples/server.key',
    credential_validator=FakeCredentialValidator(),
    debug=True
)

However it is not correct as constructor in recent release does not have debug parameter and it results in:

TypeError: __init__() got an unexpected keyword argument 'debug'

Please fix documentation or implement debugging and debug argument.

[bcoe]

@yuriiz do you mind submitting a documentation update, with the initialization format that worked for you?

[yuriiz]

SMTPServer(
self,
('0.0.0.0', 465),
None,
require_authentication=True,
ssl=True,
certfile='examples/server.crt',
keyfile='examples/server.key',
credential_validator=FakeCredentialValidator()
)

[lmas]

Did a search for 'debug' in the code and found an artefact in smtp_channel.py. self.debug is never set inside the SMTPChannel so the two lines I linked to is never run. What to do with that, remove them or keep them and revert my commit?