Add first System screens to the web view #10

renanrodrigo · 2020-05-15T19:14:07Z

Signed-off-by: Renan Rodrigo [email protected]

Signed-off-by: Renan Rodrigo <[email protected]>

mdujava · 2020-05-16T08:55:46Z

+1 Nice that we have notes visible on system page, and not hidden in submenu.

It took me a minute to decrypt (A) (M) (B) letters in front of system names, probably mention that in column description.

Signed-off-by: Renan Rodrigo <[email protected]>

renanrodrigo · 2020-05-21T22:24:41Z

Sent the last menu screen so this is ready for reviews.
Will rebase and/or squash stuff afterwards.
Any comments and suggestions are welcome.

danrodrig · 2020-05-28T21:51:01Z

Overall, looks velky dobry. 👍

Systems
- as Matej mentioned, would be nice to add a header for the (status|condition).
General information
- In recent activity, is "Service" that relevant?
- (Date Time | User | Action) Because logs, starting with "Data Time" seems more, "natural"?
System settings
- In Beaker Settings, if architecture is for supported architectures, the drop down doesn't seem like the best option. Ideally you will be able to see all at once. Maybe "Architectures: [x86_16] [i386] [Z80]"
Power Options
- Power Control, "Clear netboot" seems to me more related to Provisioning than power.
- I would try to be consistent listing actions and activity. For example, "Date time" in its own colum, and placement for common thingys, like action, or similar ones, Triger~Service.
Permissions
- Looks very dense. But I don't have better alternative ATM.

renanrodrigo · 2020-06-04T15:54:34Z

About the points I'm not sure:

"Service" in recent activity would just make clear if the call was made through the API, scheduler, web interface, etc, IMHO. Makes it easier to track where do commands come from when debugging.
Architectures is a multi-select dropdown currently, and I kept it like this - will add an example in the future.
"Clear Netboot" is listed in Power commands in the current interface, thats the reason I put it as power. I can definitely change it if people agree.
Changing permissions arrangement would be nice, as would be nice to discuss how permissions should work in the new system: how specific they need to be? What do we need to keep from current access policy, what is disposable, what needs to be added?

Everyone, any thoughts on this?

Signed-off-by: Renan Rodrigo <[email protected]>

danrodrig · 2020-06-09T09:38:32Z

About the points I'm not sure:

Me neither 😕

"Service" in recent activity would just make clear if the call was made through the API, scheduler, web interface, etc, IMHO. Makes it easier to track where do commands come from when debugging.

Yes, that's my point, if it's only relevant for debugging, I don't think should be that much visible. Most of the time it should be irrelevant.

Architectures is a multi-select dropdown currently, and I kept it like this - will add an example in the future.

I see, I checked in current Beaker. Eww.

"Clear Netboot" is listed in Power commands in the current interface, thats the reason I put it as power. I can definitely change it if people agree.

Yeah, I know. I'm questioning that. To me, the netboot is the very first step of the provisioning, while power is related to the power state of the system.

Changing permissions arrangement would be nice, as would be nice to discuss how permissions should work in the new system: how specific they need to be? What do we need to keep from current access policy, what is disposable, what needs to be added?

Even with the same amount of information, maybe there is other ways to organize it, but I did find any, yet.

danrodrig

Overall, LGTM

cbouchar · 2020-06-09T17:40:31Z

designs/systems/index.md

+for the system.
+- Notes: notes about the system, written by anyone with permissions to do so.
+- Recent Activity: small report of the recent activity in the system. The last 5 activities are shown. There is a button
+which allows the user to see all the activity for the system.


Will you really see all activity for the system or 'More activity for the system'? Will there be more detail information like in the old beaker such as field name, old value, new value or are you joining all that information into the action field. For text in the button, I'd suggest using 'More or all activity'. Since you are on the screen for a specific system, I don't think 'for the system' is necessary.

I would keep everything in the "action" field, as it improves readability and shows a higher abstraction to the user than "this field has changed to this other one". I mean all activity because only the last 5 rows are present in the card, but one may be interested in a bigger table, with filters available, to check the history for the system.

What I was suggesting is to replace text in the button from "See all activity for this system" to something more brief like "More activity". I doubt you can put ALL activity in the next screen so the next screen would also require a "more activity" button. Same applies to Power command history.

cbouchar · 2020-06-09T17:43:43Z

designs/systems/index.md

+- Operational Status: has the current status for this system and the amount of aborted recipes in the past week. Also has
+a "Report Problem" button, allowing the current user to inform the machine owner of any problem that may have happened.
+- Hardware: Has a button to show the hardware details for this system and a button to show the key/value pairs defined
+for the system.


Will you be showing screen of hardware details? Is it the same as our 'Details' selection in old beaker?

Exactly. To keep ip clean I would show those in separate sections, accessible through the button. I'm not sure yet about the format, though.

cbouchar · 2020-06-09T17:55:09Z

designs/systems/index.md

+## System details - System Settings
+
+When a user clicks "System Settings" in the horizontal menu, the main settings for the machine are presented. Settings
+can be changed if the current user has permissions to do so.


Where is user permissions defined?

In access policy definition, "Permissions" tab.

I'm not sure who the audience is for this document.....So the user knows exactly where to set this, perhaps add to the end of the sentence "which is defined beneath the Permission tab in the horizontal bar' or provide a link to the 'Permission' section in the document. It may seem obvious to you, but user may be so new they don't know this tab exists yet.

cbouchar · 2020-06-09T17:57:13Z

designs/systems/index.md

+When a user clicks "System Settings" in the horizontal menu, the main settings for the machine are presented. Settings
+can be changed if the current user has permissions to do so.
+
+The System Metadata card has options to edit the system name and labels such as description, location and lender.


Throughout I noticed you use the word 'card'. Wouldn't 'button' be better? Not sure where 'card' comes from.

Cards are the white background sections that group information in the main view. Cards can contain textual information, form fields, buttons, etc.

cbouchar · 2020-06-09T18:09:05Z

designs/systems/index.md

+The "Power Control" card will tell if the system power can be controlled remotely and will have buttons to power the
+system on and off, reboot it, interrupt and clear netboot.
+
+A table with the 5 most recent power commands is also shown. There is a button for the user to see all of the power


Should it be 'all' or 'more'? On the screen itself, I suggest not prefixing the text in the button with 'See'. In fact, I'd keep it brief 'All or more power commands'.

Same situation as above, the button would link to a specific page with a bigger table with all of the history for the system, with filters and everything.

Soo ALL history would appear on the screen? Then maybe the button text should read "All Power Commands".

cbouchar · 2020-06-09T18:25:12Z

designs/systems/index.md

+
+Install Options can be defined in the second card. The "default" set of options will always be available, for all families
+and architectures, with specific KS metadata and Kernel options for the installation. The user may click the "Add" button
+to create customized sets of options for specific families and / or architectures supported by the system, and edit them


Is there any way for user to see configuration for specific families/architectures on the screen?

Yes. The "Special Option Set" defined there is for Fedora 32 and x86_64, for instance. My main concern here is the scrolling bar when there is a lot of option sets...

cbouchar · 2020-06-09T18:32:32Z

designs/systems/index.md

+If the custom policy is selected, a default group called "Everyone" is created. More users and/or groups may be added
+by clicking an "Add" button.
+
+For every user / group defined in the policy, all specific permissions will be shown with checkboxes. Marking a checkbox


For each user? What happens when you run out of space on the screen. I'm wondering if original format is better.

For each user defined in the policy. Most systems would have the policy defined by group, or a specific set of users.
If a system particularly has a complex set of permissions, then the number would grow and a srcoll bar would be there as well... Not sure on how yet.
The original format is just ugly I would say, but we can revert back to it if there is not a viable solution after all. As Daniel said, this screen layout really has room for improvement.

I do agree the original format is ugly. I'm just concerned about growth.

cbouchar · 2020-06-10T12:10:40Z

designs/systems/index.md

+- Service: shows through which service (command line, web interface) the activity was created
+- User: name of the user who triggered / executed the activity
+- Action: Description of the activity and its effects
+


On General info screen, suggest replacing "Notes for fhis system" with "System Notes". Is it possible need a "MORE" button?

cbouchar · 2020-06-10T12:12:44Z

designs/systems/index.md

+- Service: shows through which service (command line, web interface) the activity was created
+- User: name of the user who triggered / executed the activity
+- Action: Description of the activity and its effects
+


Beneath loan, Suggest the format
Owner: beaker_user
Loaned to: no one

Add first System screens to the web view

59c7a08

Signed-off-by: Renan Rodrigo <[email protected]>

renanrodrigo added 4 commits May 19, 2020 14:31

Add System Power details to the web view

03bc17e

Signed-off-by: Renan Rodrigo <[email protected]>

Add Permission details to the web view

a3a9eb2

Signed-off-by: Renan Rodrigo <[email protected]>

Add Provision details to the web view

26aeefe

Signed-off-by: Renan Rodrigo <[email protected]>

Add Settings details to the web view

9e2104b

Signed-off-by: Renan Rodrigo <[email protected]>

renanrodrigo marked this pull request as ready for review May 21, 2020 22:23

StykMartin requested review from StykMartin, cbouchar, danrodrig and mdujava May 26, 2020 16:36

mdujava approved these changes May 26, 2020

View reviewed changes

Tweaks and fixes to the systems screens

b43dc91

Signed-off-by: Renan Rodrigo <[email protected]>

danrodrig approved these changes Jun 9, 2020

View reviewed changes

cbouchar reviewed Jun 9, 2020

View reviewed changes

cbouchar reviewed Jun 10, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add first System screens to the web view #10

Add first System screens to the web view #10

renanrodrigo commented May 15, 2020

mdujava commented May 16, 2020

renanrodrigo commented May 21, 2020

danrodrig commented May 28, 2020

renanrodrigo commented Jun 4, 2020 •

edited

Loading

danrodrig commented Jun 9, 2020

danrodrig left a comment

cbouchar Jun 9, 2020 •

edited

Loading

renanrodrigo Jun 10, 2020

cbouchar Jun 10, 2020

renanrodrigo Jun 10, 2020

cbouchar Jun 9, 2020

renanrodrigo Jun 10, 2020

cbouchar Jun 9, 2020

renanrodrigo Jun 10, 2020

cbouchar Jun 10, 2020

cbouchar Jun 9, 2020

renanrodrigo Jun 10, 2020

cbouchar Jun 9, 2020 •

edited

Loading

renanrodrigo Jun 10, 2020

cbouchar Jun 10, 2020

cbouchar Jun 9, 2020

renanrodrigo Jun 10, 2020

cbouchar Jun 9, 2020

renanrodrigo Jun 10, 2020

cbouchar Jun 10, 2020

cbouchar Jun 10, 2020

cbouchar Jun 10, 2020

Add first System screens to the web view #10

Are you sure you want to change the base?

Add first System screens to the web view #10

Conversation

renanrodrigo commented May 15, 2020

mdujava commented May 16, 2020

renanrodrigo commented May 21, 2020

danrodrig commented May 28, 2020

renanrodrigo commented Jun 4, 2020 • edited Loading

danrodrig commented Jun 9, 2020

danrodrig left a comment

Choose a reason for hiding this comment

cbouchar Jun 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cbouchar Jun 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

renanrodrigo commented Jun 4, 2020 •

edited

Loading

cbouchar Jun 9, 2020 •

edited

Loading

cbouchar Jun 9, 2020 •

edited

Loading