From 87ffe2df4d820e8824175ca149471a7f03f01c75 Mon Sep 17 00:00:00 2001 From: Pedro Rauiz Estigarribia Gestal Date: Tue, 9 Jul 2024 20:55:13 -0300 Subject: [PATCH] Added missing "needs" to GHA windows client workflows and fixed if on build jobs --- .github/workflows/build_linux_client.yml | 2 +- .github/workflows/build_linux_server.yml | 2 +- .github/workflows/build_windows_client.yml | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_linux_client.yml b/.github/workflows/build_linux_client.yml index 60e923ec..d23afeb8 100644 --- a/.github/workflows/build_linux_client.yml +++ b/.github/workflows/build_linux_client.yml @@ -79,7 +79,7 @@ jobs: # Only run this if the changes job actually detected changes OR if we are building all. # Empty array will be serialized as [] so you can simply check it in the if condition. # Second part of the condition just checks if it's not an empty string - that would mean some failure during changes job execution. - if: ${{ (!inputs.buildAll && needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }} + if: ${{ (needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }} strategy: max-parallel: 1 diff --git a/.github/workflows/build_linux_server.yml b/.github/workflows/build_linux_server.yml index fab3a8a7..a49037bb 100644 --- a/.github/workflows/build_linux_server.yml +++ b/.github/workflows/build_linux_server.yml @@ -58,7 +58,7 @@ jobs: # Only run this if the changes job actually detected changes OR if we are building all. # Empty array will be serialized as [] so you can simply check it in the if condition. # Second part of the condition just checks if it's not an empty string - that would mean some failure during changes job execution. - if: ${{ (!inputs.buildAll && needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }} + if: ${{ (needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }} strategy: max-parallel: 1 diff --git a/.github/workflows/build_windows_client.yml b/.github/workflows/build_windows_client.yml index b81a527a..77550be5 100644 --- a/.github/workflows/build_windows_client.yml +++ b/.github/workflows/build_windows_client.yml @@ -77,12 +77,13 @@ jobs: - '*.uproject' build: + needs: changes uses: ./.github/workflows/build_windows.yml # Only run this if the changes job actually detected changes OR if we are building all. # Empty array will be serialized as [] so you can simply check it in the if condition. # Second part of the condition just checks if it's not an empty string - that would mean some failure during changes job execution. - if: ${{ (!inputs.buildAll && needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }} + if: ${{ (needs.changes.outputs.BEAMPROJS != '[]' && needs.changes.outputs.BEAMPROJS != '') || inputs.buildAll }} strategy: max-parallel: 2