Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: code styling: Add rules to enforce blank lines between blocks #2048

Open
manuelwedler opened this issue Jul 12, 2023 · 0 comments
Open

Comments

@manuelwedler
Copy link
Contributor

manuelwedler commented Jul 12, 2023

We would like to enforce stricter styling rules and add blank lines between function declarations and in general code blocks. This should be done in order to be consistent in the frontend codebase.

Just did a quick research. There are ESLint rules to achieve this:
https://eslint.org/docs/latest/rules/padded-blocks is probably the way to go.
We could also consider these two:
https://eslint.org/docs/latest/rules/padding-line-between-statements
https://eslint.org/docs/latest/rules/lines-between-class-members

Since applying these will change a lot of code, I would keep it out of the scope of this PR and just create an issue for now.

Originally posted by @manuelwedler in #2031 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant