Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input is not robust (Command Line Interface) #8

Open
bebenlebricolo opened this issue Sep 24, 2018 · 0 comments
Open

Input is not robust (Command Line Interface) #8

bebenlebricolo opened this issue Sep 24, 2018 · 0 comments
Assignees
@bebenlebricolo
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@bebenlebricolo
Copy link
Owner

Use case :
-> Send random stuff to executable, wait for it...... crash!

$ FreeMyCode ùaekmkf anefjia cjdqsico

Parser should be tuned to avoid such crashes
Crash occurs :

  • Input is filled with crap (parser)
  • All arguments are not filled (3 of them are filled )
  • logger tries to access to logfile (which is empty at this time)
    -> parser should have told FreeMyCode to abort execution before.

Possible solution :
Check inputs BEFORE trying to access it.

  • Inputs are already checked, but in the FreeMyCode.cpp scope, not in the parser's scope
    -> Parser should return an error (false) as soon as it detects an error in CLI
@bebenlebricolo bebenlebricolo added bug Something isn't working invalid This doesn't seem right labels Sep 24, 2018
@bebenlebricolo bebenlebricolo self-assigned this Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bebenlebricolo bebenlebricolo

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bebenlebricolo