Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beckn-ONIX installation does not update existing key #177

Open
6 tasks
vbabuEM opened this issue Aug 12, 2024 · 7 comments
Open
6 tasks

Beckn-ONIX installation does not update existing key #177

vbabuEM opened this issue Aug 12, 2024 · 7 comments
Assignees
Labels
beckn onix beckn onix project bug Something isn't working

Comments

@vbabuEM
Copy link
Contributor

vbabuEM commented Aug 12, 2024

Description:

There is an issue when installing the Protocol Server (PS) using Beckn ONIX, where if a Network Participant (NP) is already present in the registry, the public key is not updated. This results in a mismatch between the public key in the config/default.yaml file and the one in the registry, causing communication failures.

Problem:

When the Protocol Server (PS) is installed using Beckn ONIX, and the Network Participant (NP) already exists in the registry, the NP's public key is not updated. As a result, the public key in the config/default.yaml file differs from the one in the registry, leading to communication issues.

Solution:

After the installation of the Protocol Server (PS) with Beckn ONIX, the public key in the config/default.yaml file and the one in the registry should be identical to ensure successful communication. The process should be updated to verify and align the keys post-installation.

Goals:

  • Ensure that the public key in config/default.yaml matches the public key in the registry after PS installation via Beckn ONIX.
  • Update the Beckn ONIX installation process to check and correct any public key mismatches.
  • Verify that communication between the Protocol Server and other components is functional post-installation.

Expected Outcome:

  • The public key in config/default.yaml is correctly updated and matches the one in the registry after the PS installation.
  • Communication between the Protocol Server and the registry is successful, with no failures due to key mismatches.

Acceptance Criteria:

  • The public key mismatch issue is resolved, and the keys are identical post-installation.
  • Communication between the Protocol Server and other components is tested and confirmed to be functional.
  • The Beckn ONIX installation process is updated and documented to prevent future occurrences of this issue.

Mockups / Wireframes:

NA

Product Name:

Beckn Protocol Server

Domain:

DevOps

Tech Skills Needed:

YAML Configuration, Beckn ONIX, DevOps, Registry Management

Complexity:

Medium

Category:

Bug Fix

Sub Category:

Configuration Issue

@viraj89 viraj89 added beckn onix beckn onix project bug Something isn't working labels Aug 12, 2024
@prasad-takale-eminds
Copy link
Contributor

Identified the API that updates the public and private keys on the registry. The API is /network_participants/save, but it requires cookies to update the entry on the registry.

@prasad-takale-eminds
Copy link
Contributor

Venkatesh, Venky, and I had a call to discuss the correct approach for this task. Venkatesh will confirm the approach we need to follow. For now, I'm moving this ticket to on hold.

@vbabuEM
Copy link
Contributor Author

vbabuEM commented Aug 21, 2024

Related to #176

@viraj89
Copy link

viraj89 commented Aug 22, 2024

The user flow needs to be identified and use the actual creds used on the registry of the user.

@prasad-takale-eminds
Copy link
Contributor

@emmayank When can we connect with Ravi for to get the clerification for user flow?

@prasad-takale-eminds
Copy link
Contributor

Ask user for the username and password or API key during the PS deployment and then deploy it.
otherwise give the error message for invalid username or input.

@prasad-takale-eminds
Copy link
Contributor

We can create the NP with the registered user on registry.

PR: #295

BAP installation CLI SS
Image

registry BAP NP SS
Image

BPP installation CLI SS
Image

registry BPP NP SS
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beckn onix beckn onix project bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants