[Issue #112]Implementing missing level feature: Inventory #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what i can tell this doesnt actually implement the Inventory? All this does is expose the key value to get an inventory. A consumer would still have to query the underlying DB (possible via an unsafe call on level) to get the data that they then need to parse manually anyway. |
|
This isnt valid code i dont think? Why is the RustDBInterface storing the UserState and cloning it? There is no reason for the |
akashic-records-of-the-abyss
suggested changes
Jan 4, 2025
|
Also please mark this PR as a draft and not ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing missing level features.
Fixes #112