Rework of the World crate! #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theaddonn
reviewed
Nov 24, 2024
ghost
marked this pull request as ready for review
|
I would have liked to implement biomes before i made this PR ready but i have sadly ran low on time and motivation 😅. This is a fully stable implementation to interact with the level. The code is also quite generic; this may lead to generic hell but the library provides powerful default types (at least in my opinion) so users should never have to interact with generic hell! |
theaddonn
requested changes
Dec 11, 2024
added 2 commits
December 15, 2024 13:54
theaddonn
requested changes
Dec 21, 2024
theaddonn
reviewed
Dec 21, 2024
|
@akashic-records-of-the-abyss could you also please switch over to the |
theaddonn
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant pull request, so I apologize in advance.
I am currently working on a rewrite of the World crate in BedrockRS to enhance its features and modularity. While this PR is still a work in progress and there are several changes I plan to make, I would greatly appreciate input from the maintainers regarding the code.