Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultForAllTables doesn't work as described in the docs #23

Open
j4k3 opened this issue Feb 16, 2021 · 1 comment
Open

defaultForAllTables doesn't work as described in the docs #23

j4k3 opened this issue Feb 16, 2021 · 1 comment

Comments

@j4k3
Copy link

j4k3 commented Feb 16, 2021

The configuration value defaultForAllTables does not seem to work as described in the documentation. It is, in fact not even mentioned in the hook method, getDefaultUploadFolder() at all.
I've modified the file by duplicating the following lines and appending them at line 45, modifying them like so,

    if ($subFolder['value'] === null) {
        $subFolder = $backendUserAuthentication->getTSConfig(
            'default_upload_folders.' . $table,
            $pageTs
        );
    }
    if ($subFolder['value'] === null) {
        $subFolder = $backendUserAuthentication->getTSConfig(
            'default_upload_folders.defaultForAllTables',
            $pageTs
        );
    }

It now seems to work as intended. Was this just missing, or am I doing something wrong?

@joey-bolts
Copy link
Contributor

@j4k3 From what i have been able to test it seems to be working. Is this issue still relevant, if so. How can we help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants